Closed Bug 1439721 Opened 7 years ago Closed 7 years ago

Remove WEB_PERMISSION_CLEARED telemetry code

Categories

(Firefox :: Site Identity, enhancement, P3)

Product:
Firefox
Component:
Site Identity
Version:
60 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: johannh, Assigned: dvabhinav31, Mentored)

References

Details

Attachments

(1 file, 2 obsolete files)

bug-1439721-v3.patch
(deleted), patch
johannh
: review+
Details | Diff | Splinter Review
Mentor: jhofmann
Can I work on this? Please assign the bug to me?
Attached patch Bug-1439721.patch (obsolete) (deleted) — — Splinter Review
Attachment #8953920 - Flags: review?(jhofmann)
Assignee: nobody → dvabhinav31
Status: NEW → ASSIGNED
Comment on attachment 8953920 [details] [diff] [review] Bug-1439721.patch Review of attachment 8953920 [details] [diff] [review]: ----------------------------------------------------------------- Hey, thank you for the patch, this looks good, but you can actually delete even more code. I've highlighted it here: https://searchfox.org/mozilla-central/rev/0c0ddaa7e859a2b76a56a0e2e9c0de88af166812/browser/base/content/browser.js#8080-8101 Thanks!
Attachment #8953920 - Flags: review?(jhofmann) → feedback+
Attached patch Bug-1439721v2.patch (obsolete) (deleted) — — Splinter Review
Attachment #8954712 - Flags: review?(jhofmann)
Comment on attachment 8954712 [details] [diff] [review] Bug-1439721v2.patch Review of attachment 8954712 [details] [diff] [review]: ----------------------------------------------------------------- This patch somehow touches the warning.svg file, it would be great if you could get rid of that change first. You can use hg revert -r central <path to your file> Apart from that these changes look great! Thanks!
Attachment #8954712 - Flags: review?(jhofmann)
Attached patch bug-1439721-v3.patch (deleted) — — Splinter Review
I have made all the required changes to the bug. Thanks..!!!!
Attachment #8953920 - Attachment is obsolete: true
Attachment #8954712 - Attachment is obsolete: true
Attachment #8956798 - Flags: superreview?
Attachment #8956798 - Flags: review?(jhofmann)
(In reply to abhinavdv from comment #6) > Created attachment 8956798 [details] [diff] [review] > bug-1439721-v3.patch > > I have made all the required changes to the bug. Thanks..!!!! The super review is not required and was posted by mistake by me. Sorry!!
Attachment #8956798 - Flags: superreview?
Comment on attachment 8956798 [details] [diff] [review] bug-1439721-v3.patch Review of attachment 8956798 [details] [diff] [review]: ----------------------------------------------------------------- This looks great, thank you!
Attachment #8956798 - Flags: review?(jhofmann) → review+
Hi abhinavdv, in order to get your patch landed you need to set the checkin-needed flag in the keywords field. I'll do that for you this time :)
Keywords: checkin-needed
I didn't know that. I will take care from next time. Thanks :)
https://hg.mozilla.org/mozilla-central/rev/db5849bc874c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: