Closed
Bug 1439936
Opened 7 years ago
Closed 7 years ago
Change check_spidermonkey_style.py to support sorting "util/Windows.h"
Categories
(Core :: JavaScript Engine, enhancement, P5)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
|
(deleted),
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
see patch
|
Assignee | |
Comment 1•7 years ago
|
||
Far more files #include "util/Windows.h" than <psapi.h>, so this makes the
style-checker check more things (and makes --fixup mode fix more things).
Attachment #8952729 -
Flags: review?(sphink)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8952729 [details] [diff] [review]
Change check_spidermonkey_style.py to support sorting "util/Windows.h"
Review of attachment 8952729 [details] [diff] [review]:
-----------------------------------------------------------------
I was surprised that util/Windows.h worked mixed in the middle of other include files, but it appears to be fine.
Attachment #8952729 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e657516be4498ff0fc3c88e4adee2aa84c3c5f27
Bug 1439936 - Change check_spidermonkey_style.py to support sorting "util/Windows.h". r=sfink.
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•