Nicolas Chevobbe [:nchevobbe] Assignee
	Description • 7 years ago

      No description provided.

	Nicolas Chevobbe [:nchevobbe] Assignee
	Comment 5 • 7 years ago

The bundle is not quite ready yet, but the other patches can be reviewed

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8958738 [details]
Bug 1440388 - Fix failing test with new Reps bundle; .

https://reviewboard.mozilla.org/r/227658/#review233786

Looks good to me.
R+ assuming try is green
Honza

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 7 • 7 years ago
mozreview-review

Comment on attachment 8958739 [details]
Bug 1440388 - Adapt JSONViewer to the new Reps bundle; .

https://reviewboard.mozilla.org/r/227660/#review233790

Thanks for working on this!

Please see my inline comment.

Honza

::: devtools/client/jsonview/test/browser_jsonview_url_linkification.js:24
(Diff revision 1)
>      let link = document.querySelector(".jsonPanelBox .treeTable .treeValueCell a");
> -    is(link.href, url, "The URL was linkified.");
> -    is(link.textContent, url, "The full URL is displayed.");
> +    is(link.textContent, expectedURL, "The full URL is displayed.");
> +    link.click();
> +  });
> +
> +  let newTab = await onTabLoaded;

What about reducing the amount of code by introducing a helper method that:

1) calls waitForNewTab
2) calls ContentTask.spawn + optionally clicks the label
3) waits for the new tab loaded

Custom message log text can be passed into the helper.

A flag indicating whether the label should be clicked can be passed in too.

	Nicolas Chevobbe [:nchevobbe] Assignee
	Comment 16 • 7 years ago
mozreview-review-reply

Comment on attachment 8958739 [details]
Bug 1440388 - Adapt JSONViewer to the new Reps bundle; .

https://reviewboard.mozilla.org/r/227660/#review233790

> What about reducing the amount of code by introducing a helper method that:
> 
> 1) calls waitForNewTab
> 2) calls ContentTask.spawn + optionally clicks the label
> 3) waits for the new tab loaded
> 
> Custom message log text can be passed into the helper.
> 
> A flag indicating whether the label should be clicked can be passed in too.

done

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 18 • 7 years ago
mozreview-review

Comment on attachment 8958739 [details]
Bug 1440388 - Adapt JSONViewer to the new Reps bundle; .

https://reviewboard.mozilla.org/r/227660/#review234416

Looks great now, thanks!
R+ assuming try is green
Honza

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 19 • 7 years ago
mozreview-review

Comment on attachment 8959480 [details]
Bug 1440388 - Adapt webconsole.css to the new Reps bundle; .

https://reviewboard.mozilla.org/r/228272/#review234418

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 20 • 7 years ago
mozreview-review

Comment on attachment 8958428 [details]
Bug 1440388 - devtools-reps: release v0.21.0; .

https://reviewboard.mozilla.org/r/227380/#review234420

	Pulsebot
	Comment 21 • 7 years ago

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa46f0522cfd
devtools-reps: release v0.21.0; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/6b359e9acbf4
Fix failing test with new Reps bundle; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/03b4dbb07486
Adapt JSONViewer to the new Reps bundle; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/fed69455a832
Adapt webconsole.css to the new Reps bundle; r=Honza.

	Cristian Brindusan [:cbrindusan]
	Comment 22 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/aa46f0522cfd
https://hg.mozilla.org/mozilla-central/rev/6b359e9acbf4
https://hg.mozilla.org/mozilla-central/rev/03b4dbb07486
https://hg.mozilla.org/mozilla-central/rev/fed69455a832