Update cubeb-rs, audioipc and cubeb-pulse-rs to use vendored version of cubeb-rs (v0.4.1)

Comment on attachment 8953326 [details] Bug 1440538 - P1: Remove local cubeb-rs. https://reviewboard.mozilla.org/r/222604/#review228494

Comment on attachment 8953327 [details] Bug 1440538 - P2: Update audioipc to commit 933fb48. https://reviewboard.mozilla.org/r/222606/#review228496

Comment on attachment 8953328 [details] Bug 1440538 - P3: Update cubeb-pulse-rs update.sh. https://reviewboard.mozilla.org/r/222608/#review228498

Comment on attachment 8953329 [details] Bug 1440538 - P4: Update cubeb-pulse-rs to commit f58dc34. https://reviewboard.mozilla.org/r/222610/#review228500

Comment on attachment 8953330 [details] Bug 1440538 - P5: Vendor rust crates. https://reviewboard.mozilla.org/r/222612/#review228688 r=me for the crate vendor, but I think you need to look at mda failures on the try push. Looks like a leak in cubeb.

Pushed by dglastonbury@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34deadb4772f P1: Remove local cubeb-rs. r=kinetik https://hg.mozilla.org/integration/autoland/rev/fb7e2f2bea09 P2: Update audioipc to commit 933fb48. r=kinetik https://hg.mozilla.org/integration/autoland/rev/6d9344794eb4 P3: Update cubeb-pulse-rs update.sh. r=kinetik https://hg.mozilla.org/integration/autoland/rev/765cdd7b0c46 P4: Update cubeb-pulse-rs to commit f58dc34. r=kinetik https://hg.mozilla.org/integration/autoland/rev/d798ddf4c17d P5: Vendor rust crates. r=rillian

(In reply to Ralph Giles (:rillian) | needinfo me from comment #10) > Comment on attachment 8953330 [details] > Bug 1440538 - P5: Vendor rust crates. > > https://reviewboard.mozilla.org/r/222612/#review228688 > > r=me for the crate vendor, but I think you need to look at mda failures on > the try push. Looks like a leak in cubeb. Yeah, there was a leak. I've fixed that upstream in cubeb-rs, republished to crates-io and re-vendored.

https://hg.mozilla.org/mozilla-central/rev/34deadb4772f https://hg.mozilla.org/mozilla-central/rev/fb7e2f2bea09 https://hg.mozilla.org/mozilla-central/rev/6d9344794eb4 https://hg.mozilla.org/mozilla-central/rev/765cdd7b0c46 https://hg.mozilla.org/mozilla-central/rev/d798ddf4c17d

Was cubeb supposed to be pulled once again? We now have two copy of libcubeb in the tree and this new cubeb won't compiled if there's API difference with the first cubeb

That second cubeb is an artifact of the way rust crates work for putting up on crates.io. It shouldn't be compiled in. I tried to remove it from the package but that doesn't appear to be supported. If you're having problems, do you have patches you can share so I can try locally.