Closed
Bug 1440550
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend v19
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8953673 -
Flags: review?(jdescottes)
Assignee | ||
Comment 2•7 years ago
|
||
Updated•7 years ago
|
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Comment 3•7 years ago
|
||
Comment on attachment 8953673 [details] [diff] [review]
rel-19.patch
Review of attachment 8953673 [details] [diff] [review]:
-----------------------------------------------------------------
- Meta:
- assigned, P3, enhancement, blocks meta: Done.
- commit message: OK
- less than 20 commits: OK
- TRY
- try run green: KO, test timing out needs fixing
- try run has rebuild: OK
- Manual test: OK
- README: OK
- Properties file review: N/A
- New files: OK
R+ with the test timeout extended.
(related to that there's a r? for you here: https://bugzilla.mozilla.org/show_bug.cgi?id=1440102)
::: devtools/client/debugger/new/test/mochitest/browser_dbg-babel-stepping.js
@@ +78,5 @@
> + }
> +}
> +
> +add_task(async function() {
> + requestLongerTimeout(2);
This test is timing out too frequently. Please either disable or up this to requestLongerTimeout(3).
Also please move this to the top of the test file, by convention that's where we normally set such timeouts.
Attachment #8953673 -
Flags: review?(jdescottes) → review+
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
Talos indicates performance regressions:
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=1c9c1d3f8c6463a0e0db7752038317e2d3423755&newProject=try&newRevision=d21d2fda5eb7d244ca724b999aa23787c2b5951f&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyImportant=1&framework=1
- complicated.jsdebugger.reload.DAMP : 5.79%
- custom.jsdebugger.open.DAMP : 26.85%
- custom.jsdebugger.reload.DAMP : 4.17%
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8953673 -
Attachment is obsolete: true
Attachment #8954061 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a2ad927dcc
Update Debugger Frontend v19. r=jdescottes
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•