Closed Bug 1440550 Opened 7 years ago Closed 7 years ago

Update Debugger Frontend v19

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch rel-19.patch (obsolete) (deleted) — Splinter Review
Attachment #8953673 - Flags: review?(jdescottes)
Assignee: nobody → jlaster
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8953673 [details] [diff] [review] rel-19.patch Review of attachment 8953673 [details] [diff] [review]: ----------------------------------------------------------------- - Meta: - assigned, P3, enhancement, blocks meta: Done. - commit message: OK - less than 20 commits: OK - TRY - try run green: KO, test timing out needs fixing - try run has rebuild: OK - Manual test: OK - README: OK - Properties file review: N/A - New files: OK R+ with the test timeout extended. (related to that there's a r? for you here: https://bugzilla.mozilla.org/show_bug.cgi?id=1440102) ::: devtools/client/debugger/new/test/mochitest/browser_dbg-babel-stepping.js @@ +78,5 @@ > + } > +} > + > +add_task(async function() { > + requestLongerTimeout(2); This test is timing out too frequently. Please either disable or up this to requestLongerTimeout(3). Also please move this to the top of the test file, by convention that's where we normally set such timeouts.
Attachment #8953673 - Flags: review?(jdescottes) → review+
Attached patch rel-19-2.patch (deleted) — Splinter Review
Attachment #8953673 - Attachment is obsolete: true
Attachment #8954061 - Flags: review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: