Closed
Bug 1441147
Opened 7 years ago
Closed 7 years ago
Upgrade redux and react-redux to remove react-dev warnings
Categories
(DevTools :: General, enhancement, P2)
DevTools
General
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: miker, Assigned: miker)
Details
Attachments
(1 file)
Since our upgrade to React 16 we have the following warning in the memory tool:
`"Warning: Failed prop type: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them."`
The most common cause of this error is incompatibilities between redux and the current version of react.
Assignee | ||
Updated•7 years ago
|
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8953985 [details]
Bug 1441147 - Upgrade redux and react-redux to remove react-dev warnings
https://reviewboard.mozilla.org/r/223140/#review229068
Seems legit
::: devtools/client/shared/vendor/REDUX_UPGRADING.md:1
(Diff revision 1)
> -/* This Source Code Form is subject to the terms of the Mozilla Public
> +[//]: # (
what's this syntax ? Never saw it
Attachment #8953985 -
Flags: review?(nchevobbe) → review+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)
> Comment on attachment 8953985 [details]
> Bug 1441147 - Upgrade redux and react-redux to remove react-dev warnings
>
> https://reviewboard.mozilla.org/r/223140/#review229068
>
> Seems legit
>
> ::: devtools/client/shared/vendor/REDUX_UPGRADING.md:1
> (Diff revision 1)
> > -/* This Source Code Form is subject to the terms of the Mozilla Public
> > +[//]: # (
>
> what's this syntax ? Never saw it
It is an invisible link used to provide comments in markdown.
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c0478c4185c
Upgrade redux and react-redux to remove react-dev warnings r=nchevobbe
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•