Closed Bug 1441175 Opened 7 years ago Closed 7 years ago

toolkit/content/tests/reftests/bug-442419-progressmeter-max.xul fails on win10-debug

Categories

(Testing :: General, enhancement)

Product:
Testing
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: jmaher, Assigned: NarcisB)

References

Details

Attachments

(2 files, 1 obsolete file)

Remove isDebugBuild
(deleted), patch
jmaher
: review+
Details | Diff | Splinter Review
Remove isDebugBuild3
(deleted), patch
jmaher
: review+
Details | Diff | Splinter Review
with recent changes in for bug 1353461, we have a test that was random-if on win10=opt, but needs to be on debug as well.
Attached patch Remove isDebugBuild (obsolete) (deleted) — — Splinter Review
Attachment #8954019 - Flags: review?(jmaher)
Comment on attachment 8954019 [details] [diff] [review] Remove isDebugBuild Review of attachment 8954019 [details] [diff] [review]: ----------------------------------------------------------------- you removed it from the first clause (for win7 where we can leave it in), but we need to remove it from the second clause. Can you make this work in mozreview also unless you have a way to land it on autoland without mozreview.
Attachment #8954019 - Flags: review?(jmaher) → review-
Attached patch Remove isDebugBuild (deleted) — — Splinter Review
Removed from Windows 10
Attachment #8954029 - Flags: review?(jmaher)
Comment on attachment 8954029 [details] [diff] [review] Remove isDebugBuild Review of attachment 8954029 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8954029 - Flags: review?(jmaher) → review+
Attachment #8954019 - Attachment is obsolete: true
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00b83d62b16b Remove_isDebugBuild toolkit/content/tests/reftests/bug-442419-progressmeter-max.xul fails on win10-debug. r=jmaher
Backout by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2018e0f39d9e Backed out changeset 00b83d62b16b for reftest failures "SyntaxError: missing )". CLOSED TREE
Attached patch Remove isDebugBuild3 (deleted) — — Splinter Review
Solved "EXCEPTION: SyntaxError: missing ) in parenthetical"
Attachment #8954052 - Flags: review?(jmaher)
Attachment #8954052 - Flags: review?(jmaher) → review+
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/478608ccfa70 Remove isDebugBuild - toolkit/content/tests/reftests/bug-442419-progressmeter-max.xul fails on win10-debug. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/478608ccfa70
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee: nobody → nbeleuzu
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: