Closed
Bug 1441340
Opened 7 years ago
Closed 7 years ago
mozilla-esr60 creation follow-ups
Categories
(Developer Services :: Mercurial: hg.mozilla.org, enhancement)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(4 files)
We forgot to do some things when we created the mozilla-esr60 repo...
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
I don't think we want to add esr60 to mozilla-unified yet. My understanding is that the existing clone is intended to be wiped out re-created closer to the regular branch date late in the Beta60 cycle.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8954212 [details]
ansible/hg-ssh: generate bundles for mozilla-esr60 (bug 1441340);
https://reviewboard.mozilla.org/r/223374/#review229576
LGTM.
Attachment #8954212 -
Flags: review?(sheehan) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8954214 [details]
mozautomation: add esr60 (bug 1441340);
https://reviewboard.mozilla.org/r/223378/#review229570
::: pylib/mozautomation/mozautomation/repository.py:78
(Diff revision 1)
> 'esr17': 'releases/mozilla-esr17',
> 'esr24': 'releases/mozilla-esr24',
> 'esr31': 'releases/mozilla-esr31',
> 'esr38': 'releases/mozilla-esr38',
> 'esr45': 'releases/mozilla-esr45',
> 'esr52': 'releases/mozilla-esr52',
Should there be an entry here as well?
Assignee | ||
Comment 7•7 years ago
|
||
Per RyanVM's comments, we should hold off on everything except the bundle generation.
I confirm Ryan's comment. After talking to :bhearsum, my request to create the ESR60 branch was too much ahead of time. It turns out we can use a testing branch for the bulk of our tests. We may use ESR60 for final testing, close to the end of the beta cycle.
I'm sorry about the fuss created by bug 1438799.
Blocks: esr60
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> I don't think we want to add esr60 to mozilla-unified yet. My understanding
> is that the existing clone is intended to be wiped out re-created closer to
> the regular branch date late in the Beta60 cycle.
We don't to wipe this branch anymore. Firefox ESR 60.0 goes to build on April 30th. I think we're good to resume the follow ups. What do you think :gps?
Speaking of which, would it be possible to get the latest mozilla-beta pushed on top of mozilla-esr60?
Flags: needinfo?(gps)
Blocks: 1452911
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8954213 [details]
ansible/hg-ssh: add esr60 to mozilla-unified (bug 1441340);
https://reviewboard.mozilla.org/r/223376/#review240954
This looks fine to me. Go ahead and land whenever RelEng is happy.
Attachment #8954213 -
Flags: review?(ryanvm) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8954214 [details]
mozautomation: add esr60 (bug 1441340);
https://reviewboard.mozilla.org/r/223378/#review240958
::: pylib/mozautomation/mozautomation/repository.py:47
(Diff revision 1)
> 'c-b': ('comm-beta',),
> 'cb': ('comm-beta',),
> 'c-r': ('comm-release',),
> 'cr': ('comm-release',),
>
> - 'releases': ('esr52', 'esr45', 'release', 'beta', 'aurora', 'central'),
> + 'releases': ('esr60', 'esr52', 'esr45', 'release', 'beta', 'aurora', 'central'),
Move esr45 to obsolete while you're here.
Attachment #8954214 -
Flags: review?(ryanvm) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 15•7 years ago
|
||
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/559f3ab51a46
ansible/hg-ssh: generate bundles for mozilla-esr60 ; r=sheehan
https://hg.mozilla.org/hgcustom/version-control-tools/rev/21b05adf5763
ansible/hg-ssh: add esr60 to mozilla-unified ; r=RyanVM
https://hg.mozilla.org/hgcustom/version-control-tools/rev/49b3bf5034af
mozautomation: add esr60 ; r=RyanVM
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 16•7 years ago
|
||
the description for esr60 on https://hg.mozilla.org/releases still says "unknown".
Comment 17•7 years ago
|
||
The repo-level .hgrc files on hgweb11 and hgssh4 don't match. hgweb11 has a generic new-repository config, and hgssh4 has a custom config with the missing description and some other hooks enabled. So it appears the hgrc files aren't replicating for some reason. I ran `/var/hg/venv_tools/bin/hg config -e -l` on both hosts and running on hgweb11 gave the following output: "not trusting file /repo_local/mozilla/mozilla/releases/mozilla-esr60/.hg/hgrc from untrusted user root, group root". Comparing the permissions on the .hg/hgrc file of esr52 vs esr60, esr52 has hg:hg permissions and esr60 has root:root.
From this information, my best guess is the replication system isn't working due to these permissions. We can copy over the hgrc file and correct the permissions on the hgweb hosts and the description should appear as normal. The cause of the permissions mismatch will need some more investigation.
Comment 18•7 years ago
|
||
hgweb13 also had an incorrect hgrc. I've manually fixed both. Not sure why they're getting out of sync. :-\
Comment 19•7 years ago
|
||
mozreview-review |
Comment on attachment 8954213 [details]
ansible/hg-ssh: add esr60 to mozilla-unified (bug 1441340);
https://reviewboard.mozilla.org/r/223376/#review243796
Attachment #8954213 -
Flags: review?(sheehan)
Comment 20•7 years ago
|
||
mozreview-review |
Comment on attachment 8954214 [details]
mozautomation: add esr60 (bug 1441340);
https://reviewboard.mozilla.org/r/223378/#review243794
Attachment #8954214 -
Flags: review?(sheehan)
Assignee | ||
Comment 21•7 years ago
|
||
I /think/ everything is sorted out here. Please file a new bug for any outstanding issues with releases/mozilla-esr60.
Flags: needinfo?(gps)
Comment 22•7 years ago
|
||
A spot was missed and as a result, firefoxtree doesn't know what it is. Confirmed locally that this fixes it.
Attachment #8971375 -
Flags: review?(gps)
Updated•7 years ago
|
Attachment #8971375 -
Flags: review?(gps) → review+
Comment 23•7 years ago
|
||
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/e33dd348117c
mozautomation: add missing esr60 entries to repository.py ; r=sheehan
You need to log in
before you can comment on or make changes to this bug.
Description
•