Closed
Bug 1441439
Opened 7 years ago
Closed 7 years ago
Remove dependency to hidden.html in test_click.py, test_legacy_mouse_action.py, test_visibility.py
Categories
(Remote Protocol :: Marionette, enhancement, P3)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1434907
People
(Reporter: whimboo, Unassigned, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=py])
User Story
For steps in how to get started please consult our documentation for new users: https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html In the case of questions you can find us on IRC in the #ateam channel.
The following tests are using external HTML testcases, which are simple enough to get integrated as data URL directly into the test. For Marionette unit tests we make use of the `inline` method. Here an example:
https://dxr.mozilla.org/mozilla-central/rev/a928be5dacc3b544e29c0612b3f8cda6447df802/testing/marionette/harness/marionette_harness/tests/unit/test_typing.py#14
The same method should be applied to the following tests:
https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/tests/unit/click.py
https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/tests/unit/test_legacy_mouse_action.py
https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/tests/unit/test_visibility.py
By adding as minimal necessary code from the following HTML testcase:
https://dxr.mozilla.org/mozilla-central/rev/default/testing/marionette/harness/marionette_harness/www/hidden.html
The HTML testcase file should be deleted afterward.
Comment 2•7 years ago
|
||
Of course. Please submit a patch and flag whimboo as the reviewer.
Comment 3•7 years ago
|
||
(In reply to Andreas Tolfsen ‹:ato› from comment #2)
> Of course. Please submit a patch and flag whimboo as the reviewer.
Isn't this bug the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1434907
Comment 4•7 years ago
|
||
(In reply to Venkatesh Prabhu :vprabhu from comment #3)
> (In reply to Andreas Tolfsen ‹:ato› from comment #2)
> > Of course. Please submit a patch and flag whimboo as the reviewer.
>
> Isn't this bug the same as
> https://bugzilla.mozilla.org/show_bug.cgi?id=1434907
It appears to cover different files.
Reporter | ||
Comment 5•7 years ago
|
||
It is, sorry. The mouse actions test has been renamed, so it slipped through. Jose, I hope you will find something else.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Unfortunate. I was setting up the enviroment, so no time 'wasted'. Glad it's been solved. I will look for a different one soon.
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•