Closed
Bug 1441570
Opened 7 years ago
Closed 6 years ago
Add automated test for "Top Sites - Context menu - User tiles - Edit"
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox60 | --- | wontfix |
People
(Reporter: icrisan, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
testrail link: https://testrail.stage.mozaws.net/index.php?/cases/view/129987&group_by=cases:section_id&group_order=asc&group_id=14963
Preconditions: The context menu for Default Top Sites is opened.
Steps:
1. Click the "Edit" button.
2. Edit the name field and click the blue "Save" button.
Expected results:
Step 1: The Top Sites edit form is displayed.
Step 2: The Top Site's name is changed and it is pinned in that position.
Reporter | ||
Comment 1•7 years ago
|
||
Attachment #8954735 -
Flags: review?(edilee)
Updated•7 years ago
|
Updated•7 years ago
|
Attachment #8954735 -
Flags: review?(edilee) → review?(usarracini)
Comment 2•7 years ago
|
||
Thanks for writing this test and the one in bug 1410828! Is there any way you could make these changes via a PR against our github repo? These tests generally land there and then land in mozilla central when we export all the latest changes together. That way we don't have to backport these changes into our github repo at a later time. See this PR as an example: https://github.com/mozilla/activity-stream/pull/3970
Flags: needinfo?(icrisan)
Comment 3•7 years ago
|
||
Reporter | ||
Comment 4•7 years ago
|
||
(In reply to Ursula Sarracini (:ursula) from comment #2)
> Thanks for writing this test and the one in bug 1410828! Is there any way
> you could make these changes via a PR against our github repo? These tests
> generally land there and then land in mozilla central when we export all the
> latest changes together. That way we don't have to backport these changes
> into our github repo at a later time. See this PR as an example:
> https://github.com/mozilla/activity-stream/pull/3970
Added the patches to the github also.
Thank you for the PR example!
Flags: needinfo?(icrisan)
Comment 5•7 years ago
|
||
Comment on attachment 8954735 [details] [diff] [review]
topSitesContextMenuEdit
Moved to github. Will review there. Thanks!
Attachment #8954735 -
Flags: review?(usarracini)
Comment 6•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/116f0dc504734947c7dd3725dcac9dbf2f3be756
Bug 1441570 - Add a test to verify that a topsite can be edited from the context menu. (#4026)
* Bug 1441570 - Add a test to verify that a topsite can be edited from the context menu.
* fixed the lint error
* removed the explicit check
Comment 7•7 years ago
|
||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 8•7 years ago
|
||
Updated•7 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/c76c9c9768ccbc28040ea4a06eba2dbbdcbc611a
Revert 'Bug 1441570 - Add a test to verify that a topsite can be edited from the context menu.'
https://github.com/mozilla/activity-stream/commit/3f4bcec7c9bc86b28a097ffc40dc63de42b96d36
Merge pull request #4031 from sarracini/revert_bug1441570
Revert 'Bug 1441570 - Add a test to verify that a topsite can be edited from the context menu.'
Updated•7 years ago
|
Iteration: 60.4 - Mar 12 → 61.1 - Mar 26
Updated•7 years ago
|
Updated•7 years ago
|
Severity: normal → enhancement
Updated•7 years ago
|
Assignee: icrisan → nobody
Iteration: 61.1 - Mar 26 → 61.4 - May 7
Priority: P1 → P2
Updated•7 years ago
|
Iteration: 61.4 - May 7 → 62.1 - May 21
Updated•7 years ago
|
Iteration: 62.1 - May 21 → 62.2 - Jun 4
Updated•7 years ago
|
Iteration: 62.2 - Jun 4 → 63.1 - July 9
Updated•6 years ago
|
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Iteration: 63.1 - July 9 → ---
Updated•6 years ago
|
Resolution: FIXED → WONTFIX
Assignee | ||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•