Closed Bug 1441929 Opened 7 years ago Closed 6 years ago

--theme-search-overlays-semitransparent is defined but never referenced

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1488917

People

(Reporter: jaws, Unassigned)

References

Details

Bug 1408562 introduced the --theme-search-overlays-semitransparent property but never referenced it.
Flags: needinfo?(jlaster)
Thanks! Will fix it soon
Flags: needinfo?(jlaster)
Bug 1441882 added a test that catches these types of errors. When fixing this, the entry for this bug will need to be removed from the whitelist in browser_parsable_css.js.
Hey, a number of these bugs have been fixed by that github issue. Should we mark the bugzilla bugs as 'fixed' now, or do we wait for a merge from github first?
Flags: needinfo?(jlaster)
I'm good doing either. Lets mark this as finished and we can re-open if anything gets reverted.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(jlaster)
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(jlaster)
Yes there was a mistake with the initial fix for https://github.com/devtools-html/debugger.html/issues/5566 which removed --search-overlays-semitransparent instead of --theme-search-overlays-semitransparent. We reverted the mistake but didn't remove the one that was really needed. Reopened the issue.
Flags: needinfo?(jlaster)
Product: Firefox → DevTools
The reference (and the mention in browser_parsable_css) should finally go away with v87 of the debugger. Took almost 60 releases but we did it :)
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.