Closed
Bug 1442295
Opened 7 years ago
Closed 7 years ago
Add a few missing includes
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
As part of bug 1438688, I am generating a very simple .cpp file with only a few includes. This revealed two missing includes: nsTArray.h needs mozalloc.h for moz_xmalloc and nsTStringRepr.h needs fallible.h for fallible.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8955261 -
Flags: review?(erahm)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8955261 [details] [diff] [review]
Add two missing includes in XPCOM.
Review of attachment 8955261 [details] [diff] [review]:
-----------------------------------------------------------------
::: xpcom/ds/nsTArray.h
@@ +17,5 @@
> #include "mozilla/fallible.h"
> #include "mozilla/MathAlgorithms.h"
> #include "mozilla/MemoryReporting.h"
> #include "mozilla/Move.h"
> +#include "mozilla/mozalloc.h"
I guess this should be before 'Move'
Attachment #8955261 -
Flags: review?(erahm) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #2)
> > #include "mozilla/Move.h"
> > +#include "mozilla/mozalloc.h"
>
> I guess this should be before 'Move'
Why is that? Isn't it alphabetical?
|
|
||
Comment 4•7 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #3)
> (In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment
> #2)
> > > #include "mozilla/Move.h"
> > > +#include "mozilla/mozalloc.h"
> >
> > I guess this should be before 'Move'
>
> Why is that? Isn't it alphabetical?
Oh right that's a z not a v.
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•7 years ago
|
||
This builds fine on OSX, but I'm seeing some weirdness on Linux with my other patches, so I want to make sure it builds there, too.
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•7 years ago
|
||
Linux was fine. The build problem I was seeing is unrelated to this patch.
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6384f3478169
Add two missing includes in XPCOM. r=erahm
Keywords: checkin-needed
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•