Closed
Bug 1442597
Opened 7 years ago
Closed 7 years ago
Can't drag the Mobile Bookmarks folder
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox58 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: regression)
Attachments
(1 file)
This is a regression from bug 1423896 - all the "All Bookmarks" folders should be able to be copied to another folder, however the Mobile Bookmarks folder cannot be dragged at the moment.
This is a simple fix as I'd missed including it in one of the functions.
Comment 1•7 years ago
|
||
How do you feel about going the other way and disabling copying of "All Bookmarks" and its "children"? On the one hand, it makes sense we treat them like any other folder or query; on the other, this makes it easy to create confusing cycles in the UI if you, for example, drag "All Bookmarks" into the menu or toolbar.
Flags: needinfo?(standard8)
Assignee | ||
Comment 2•7 years ago
|
||
Marco & I discussed changing how copy & paste worked, and we decided for now to keep it the same. It can lead to confusing UI, and we don't know if people rely on it or not (hopefully not but...). We're hoping for a library window re-design sometime so this may go away anyway.
Flags: needinfo?(standard8)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8955524 [details]
Bug 1442597 - Can't drag/copy the Mobile bookmarks folder shortcut.
https://reviewboard.mozilla.org/r/224680/#review230696
::: browser/components/places/tests/browser/browser_copy_query_without_tree.js:69
(Diff revision 1)
> + let mobileCopyNode = library.ContentTree.view.view.nodeForTreeIndex(0);
> + is(mobileCopyNode.type,
> + Ci.nsINavHistoryResultNode.RESULT_TYPE_FOLDER_SHORTCUT,
> + "copy is still a folder shortcut");
> +
> + PlacesUtils.bookmarks.removeItem(mobileCopyNode.itemId);
ARGH!
Attachment #8955524 -
Flags: review?(mak77) → review+
Comment hidden (mozreview-request) |
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a170c4ecc80d
Can't drag/copy the Mobile bookmarks folder shortcut. r=mak
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•7 years ago
|
status-firefox58:
--- → unaffected
status-firefox59:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Comment 8•7 years ago
|
||
Can no longer reproduce this issue on Firefox Nightly 60.0b16 (20180427210249) on Windows 10x64.
[bugday-20180502]
Comment 9•7 years ago
|
||
(In reply to Tom Bannister from comment #8)
> (20180427210249)
Apologies, posted wrong build ID
(20180426170554)
You need to log in
before you can comment on or make changes to this bug.
Description
•