Brendan Dahl [:bdahl] Assignee
	Description • 6 years ago

With the removal of editMenuOverlay, baseMenuOverlay, and places.xul it should now be possible to remove macBrowserOverlay by using the preprocessor to include the needed pieces directly into hiddenWindow.xul and browser.xul.

Feel free to move this bug, I'm not quite sure what component this should go in.

	Brendan Dahl [:bdahl] Assignee
	Comment 1 • 6 years ago

*places.xul = placesOverlay.xul

	Brendan Dahl [:bdahl] Assignee
	Comment 2 • 6 years ago

A preview of what this would look like is in https://hg.mozilla.org/try/rev/be87eb3a200a300184d4a7dcfb6b94fd2d35b1af. Where the overlay was used, we basically need to include the browser dtd files and another include file that is basically the rest of macBrowserOverlay.xul file.

	:Gijs (he/him)
	Comment 4 • 6 years ago
mozreview-review

Comment on attachment 8959698 [details]
Bug 1442829: Remove macBrowserOverlay.xul.

https://reviewboard.mozilla.org/r/228524/#review234366

Woop! I think we can also remove browserMountPoints from pageInfo.xul, and then `hg rm` the file, too. With that, r=me.

::: browser/base/content/aboutDialog.xul
(Diff revision 1)
> -#ifdef XP_MACOSX
> -#include browserMountPoints.inc
> -#endif

After removing this from pageinfo.xul as well, I think there are no more uses of this left in the tree, so it can be removed (yay!)

::: browser/base/content/pageinfo/pageInfo.xul:418
(Diff revision 1)
>  #ifdef XP_MACOSX
>  #include ../browserMountPoints.inc
>  #endif

I think this should also be removed?

	Pulsebot
	Comment 6 • 6 years ago

Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44eb7c6b5b76
Remove macBrowserOverlay.xul. r=Gijs

	Andreea Pavel [:apavel]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/44eb7c6b5b76