Closed Bug 1442961 Opened 7 years ago Closed 7 years ago

Remove the windowdragbox element and binding

Categories

(Toolkit :: XUL Widgets, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

The element is used only in pageInfo.xul and the binding doesn't do anything meaningful on Windows and Mac: https://searchfox.org/mozilla-central/rev/6cf5ac594a21db6df359dc49f4aa651fef59a27b/toolkit/modules/WindowDraggingUtils.jsm#7,14-16
Comment on attachment 8955852 [details] Bug 1442961 - Remove the windowdragbox element and binding. https://reviewboard.mozilla.org/r/224870/#review230914 Code analysis found 1 defect in this patch: - 1 defect found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: browser/base/content/browser.js:1548 (Diff revision 1) > > gNavToolbox.addEventListener("customizationstarting", CustomizationHandler); > gNavToolbox.addEventListener("customizationending", CustomizationHandler); > > + if (AppConstants.platform == "linux") { > + let tmp = {}; Error: 'tmp' is already declared in the upper scope. [eslint: no-shadow]
Comment on attachment 8955852 [details] Bug 1442961 - Remove the windowdragbox element and binding. https://reviewboard.mozilla.org/r/224870/#review230958 ::: browser/base/content/browser.js:1546 (Diff revision 2) > + if (AppConstants.platform == "linux") { > + let { WindowDraggingElement } = > + ChromeUtils.import("resource://gre/modules/WindowDraggingUtils.jsm", {}); > + new WindowDraggingElement(document.getElementById("titlebar")); > + } Shouldn't this be done in pageInfo.js as well ?
(In reply to Tim Nguyen :ntim from comment #4) > Comment on attachment 8955852 [details] > Bug 1442961 - Remove the windowdragbox element and binding. > > https://reviewboard.mozilla.org/r/224870/#review230958 > > ::: browser/base/content/browser.js:1546 > (Diff revision 2) > > + if (AppConstants.platform == "linux") { > > + let { WindowDraggingElement } = > > + ChromeUtils.import("resource://gre/modules/WindowDraggingUtils.jsm", {}); > > + new WindowDraggingElement(document.getElementById("titlebar")); > > + } > > Shouldn't this be done in pageInfo.js as well ? No. The windowdragbox doesn't do anything on Linux.
Comment on attachment 8955852 [details] Bug 1442961 - Remove the windowdragbox element and binding. https://reviewboard.mozilla.org/r/224870/#review231058
Attachment #8955852 - Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c78fcb403361 Remove the windowdragbox element and binding. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: