Open Bug 1442997 Opened 7 years ago Updated 2 years ago

Disable favicons still newtabpage show icon in Firefox60(esr branch)

Categories

(Firefox :: General, defect, P5)

60 Branch
defect

Tracking

()

REOPENED

People

(Reporter: u601173, Unassigned)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 Build ID: 20180304102248 Steps to reproduce: Like above disable favicons, restart, open a blank tab, icon is shown
Component: Untriaged → Activity Streams: Newtab
:hulmelo can you go through how you disable favicons?
Flags: needinfo?(hulmelomla)
(In reply to Tim Spurway [:tspurway] from comment #1) > :hulmelo can you go through how you disable favicons? browser.chrome.favicons browser.chrome.site_icons
Flags: needinfo?(hulmelomla) → needinfo?(tspurway)
Those prefs aren't meant to control the images on the newtab page
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(tspurway)
Resolution: --- → WONTFIX
Attached image The issue (deleted) —
(In reply to Tim Spurway [:tspurway] from comment #3) > Those prefs aren't meant to control the images on the newtab page Images? Meant the icon!
Ni for comment 4tspurway@mozilla.com
Flags: needinfo?(tspurway)
Oops for comment 4 please ignore comment 5
This might have been caused by bug 1401955. Where `setIcon` is called directly to avoid flashing https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/base/content/tabbrowser.js#778 But maybe it should check `shouldLoadFavicon` first? https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/base/content/tabbrowser.js#818-821 Where that method might get cleaned up in removing one of those two prefs in bug 1423993.
Status: RESOLVED → REOPENED
Component: Activity Streams: Newtab → General
Depends on: 1401955
Ever confirmed: true
Flags: needinfo?(tspurway)
Resolution: WONTFIX → ---
That doesn't seem particularly important to me (it may be wontfix), since these prefs are not exposed via preferences UI AFAIK.
Priority: -- → P5
(In reply to Johann Hofmann [:johannh] from comment #8) > That doesn't seem particularly important to me (it may be wontfix), since > these prefs are not exposed via preferences UI AFAIK. with Windows Group Policy Support this is a must for enterprises and next ESR60 will be released soon So P5 or won't fix seems odd as this is a legitimate bug
Flags: needinfo?(jhofmann)
(In reply to u595893 from comment #9) > (In reply to Johann Hofmann [:johannh] from comment #8) > > That doesn't seem particularly important to me (it may be wontfix), since > > these prefs are not exposed via preferences UI AFAIK. > > with Windows Group Policy Support this is a must for enterprises and next > ESR60 will be released soon > So P5 or won't fix seems odd as this is a legitimate bug Ah, if this is a legitimate concern for enterprise policies I'm happy to help resolve it. Felipe, can you help categorize the priority/urgency for this? Thanks!
Flags: needinfo?(jhofmann) → needinfo?(felipc)
We don't a policy through GPO to disable favicons*, so it's not of immediate concern. Having said that, ESR 60 will continue to support Autoconfig, so it'll remain possible to change these prefs through that, and more people might be interested in Firefox deployments now. * (we could accept a patch if someone writes it)
Flags: needinfo?(felipc)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: