See https://clang.llvm.org/extra/clang-tidy/checks/readability-static-accessed-through-instance.html enabled at review phase in bug 1422363

Comment on attachment 8955987 [details] Bug 1443080 - Use the static call for static methods (not instance) https://reviewboard.mozilla.org/r/224928/#review233336

Comment on attachment 8955988 [details] Bug 1443080 - Now that we use static call, some var instances are not needed anymore https://reviewboard.mozilla.org/r/224930/#review233338

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s db5b01de1a64840c33a8b5506054448d78720dbf -d 3606a48f0183: rebasing 452124:db5b01de1a64 "Bug 1443080 - Use the static call for static methods (not instance) r=Ehsan" merging accessible/base/nsAccessibilityService.cpp merging accessible/xpcom/xpcAccessibilityService.cpp merging dom/base/nsDOMWindowUtils.cpp merging dom/base/nsGlobalWindowOuter.cpp merging dom/canvas/CanvasRenderingContext2D.cpp merging dom/ipc/TabChild.cpp merging dom/xul/XULDocument.cpp merging editor/libeditor/HTMLEditRules.cpp merging extensions/spellcheck/src/mozInlineSpellChecker.cpp merging ipc/glue/IPCStreamUtils.cpp merging js/src/jit/BaselineCacheIRCompiler.cpp merging js/src/jit/BaselineCompiler.cpp merging js/src/jit/BaselineIC.cpp merging js/src/jit/CacheIRCompiler.cpp merging js/src/jit/CodeGenerator.cpp merging js/src/jit/IonCacheIRCompiler.cpp merging js/src/jit/shared/CodeGenerator-shared.cpp merging js/src/jsnum.cpp merging js/src/vm/Runtime.cpp merging js/src/wasm/WasmBaselineCompile.cpp merging js/src/wasm/WasmStubs.cpp merging layout/base/PresShell.cpp merging layout/generic/nsGfxScrollFrame.cpp merging layout/generic/nsSimplePageSequenceFrame.cpp merging layout/painting/FrameLayerBuilder.cpp merging layout/svg/nsSVGIntegrationUtils.cpp merging layout/xul/nsMenuPopupFrame.cpp merging media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp merging toolkit/components/extensions/MatchPattern.cpp merging toolkit/xre/nsAppRunner.cpp merging widget/nsBaseWidget.cpp warning: conflicts while merging js/src/wasm/WasmStubs.cpp! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53bdcd5937cd Use the static call for static methods (not instance) r=Ehsan https://hg.mozilla.org/integration/autoland/rev/7d509bb8a35d Now that we use static call, some var instances are not needed anymore r=Ehsan

Backout by ccoroiu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1117fa567eb Backed out 2 changesets for spidermonkey build bustage at build/src/js/src/jit/BaselineCacheIRCompiler.cpp

Backed out 2 changesets (bug 1443080) for spidermonkey build bustage at build/src/js/src/jit/BaselineCacheIRCompiler.cpp Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7d509bb8a35d278c15597bff0a0e7855479987e3 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=167878143&repo=autoland&lineNumber=1248 Backout: https://hg.mozilla.org/integration/autoland/rev/b1117fa567eb9067f2816a813046a129406f20cf

About the failure, this is SM arm64 only. Benjamin Bouvier told me that on this platform, it isn't a static method: https://searchfox.org/mozilla-central/source/js/src/jit/arm64/vixl/MacroAssembler-vixl.h#2264 Seems that the solution is to backout the change on MacroAssembler::getStackPointer() on js/ Ehsan, is that ok with you?

Sure!

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e6c8f65ed723 Use the static call for static methods (not instance) r=Ehsan https://hg.mozilla.org/integration/autoland/rev/777cffb761a2 Now that we use static call, some var instances are not needed anymore r=Ehsan

https://hg.mozilla.org/mozilla-central/rev/e6c8f65ed723 https://hg.mozilla.org/mozilla-central/rev/777cffb761a2