Closed
Bug 1443088
Opened 7 years ago
Closed 7 years ago
Compilation on ARM fail in ANGLE: g++: error: unrecognized command line option '-msse2'
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: ashie, Assigned: m_kato)
References
Details
Attachments
(2 files)
Compilation of Firefox against Renesas RZ/G1M (Linux/ARM) is failed after bug1440849 is landed:
13:09.41 arm-poky-linux-gnueabi-g++: error: unrecognized command line option '-msse2'
13:09.41 /home/vagrant/rzg1-bsp/build/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/firefox/git-r0/git/config/rules.mk:1047: recipe for target 'Float16ToFloat32.o' failed
13:09.41 make[4]: *** [Float16ToFloat32.o] Error 1
13:09.41 /home/vagrant/rzg1-bsp/build/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/firefox/git-r0/git/config/recurse.mk:73: recipe for target 'gfx/angle/targets/angle_common/target' failed
13:09.41 make[3]: *** [gfx/angle/targets/angle_common/target] Error 2
It seems that it's a similar issue with bug1434589.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8956346 [details]
Bug 1443088 - Don't use SSE2 flag on non-Intel platform.
https://reviewboard.mozilla.org/r/225206/#review231888
::: gfx/angle/moz.build.common:3
(Diff revision 1)
> AllowCompilerWarnings()
>
> +if CONFIG['INTEL_ARCHITECTURE']:
Does this mean x86, or Intel specifically? I'm assuming AMD+SSE2 would be supported by this?
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Comment on attachment 8956346 [details]
> Bug 1443088 - Don't use SSE2 flag on non-Intel platform.
>
> https://reviewboard.mozilla.org/r/225206/#review231888
>
> ::: gfx/angle/moz.build.common:3
> (Diff revision 1)
> > AllowCompilerWarnings()
> >
> > +if CONFIG['INTEL_ARCHITECTURE']:
>
> Does this mean x86, or Intel specifically? I'm assuming AMD+SSE2 would be
> supported by this?
INTEL_ARCHITECTURE means x86 and x86_64 target includes all intel compatible CPU (Intel, AMD, VIA and etc)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8956346 [details]
Bug 1443088 - Don't use SSE2 flag on non-Intel platform.
https://reviewboard.mozilla.org/r/225206/#review231892
Attachment #8956346 -
Flags: review?(jgilbert) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/5fa8ee6d00d7
Don't use SSE2 flag on non-Intel platform. r=jgilbert
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•7 years ago
|
Assignee: nobody → m_kato
You need to log in
before you can comment on or make changes to this bug.
Description
•