Closed
Bug 1443117
Opened 7 years ago
Closed 7 years ago
keypress events for non-printable keys should be fired even in Nightly until Google fixes bug 1442528 and bug 1442847
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
Until Google fixes their bugs of their apps around non-keypress handling, let's back out the patch for bug 1440189 temporarily.
|
Assignee | |
Updated•7 years ago
|
|
||
Comment 1•7 years ago
|
||
How about flipping "dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content" instead of backing out the entire patch? Automated tests can continue running by enabling the pref. It will catch regressions and will prevent wrong uses of keypress events in chrome from sneaking in.
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #1)
> How about flipping
> "dom.keyboardevent.keypress.
> dispatch_non_printable_keys_only_system_group_in_content" instead of backing
> out the entire patch? Automated tests can continue running by enabling the
> pref.
Is it possible quickly? How? The patch just changed the all.js. So, I'd just back it out, not backing out any other changes in Gecko.
Flags: needinfo?(VYV03354)
|
|
||
Comment 4•7 years ago
|
||
(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #3)
> Is it possible quickly? How? The patch just changed the all.js. So, I'd just
> back it out, not backing out any other changes in Gecko.
I'm fine with this, then.
Flags: needinfo?(VYV03354)
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8956037 [details]
Bug 1443117 - Restart to dispatch "keypress" event for non-printable keys and key combinations on Nightly and early-Beta until Google fixes related bugs of their web apps
https://reviewboard.mozilla.org/r/224978/#review230956
Attachment #8956037 -
Flags: review?(bugs) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/874144c920a0
Restart to dispatch "keypress" event for non-printable keys and key combinations on Nightly and early-Beta until Google fixes related bugs of their web apps r=smaug
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•