Closed
Bug 1443154
Opened 6 years ago
Closed 6 years ago
Dismissing a "Saved to Pocket" card wrongly dismisses a "Bookmarked" card with the same content
Categories
(Firefox :: New Tab Page, defect, P3)
Firefox
New Tab Page
Tracking
()
RESOLVED
DUPLICATE
of bug 1470211
Tracking | Status | |
---|---|---|
firefox58 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | wontfix |
People
(Reporter: cmuresan, Assigned: ursula)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
image/gif
|
Details |
[Affected versions]: - Nightly 60.0a1 [Affected Platforms]: - All Windows - All Mac - All Linux [Prerequisites]: - You are logged into Pocket or have a temporary cookie in order to save pages to Pocket [Steps to reproduce]: 1. Open the browser with a new profile. 2. Navigate to a website. (eg. https://en.wikipedia.org/wiki/Thorium) 3. Save the page to Pocket. 4. Bookmark the page and open a New Tab. 5. Dismiss the "Saved to Pocket" card and observe the behavior. [Expected results]: - Only the "Saved to Pocket" card is dismissed. [Actual results]: - The Bookmarked card is also dismissed. [Notes]: - If you dismiss the "Bookmarked" card, the "Saved to Pocket" one will remain. - Attached a screen recording of the issue.
Updated•6 years ago
|
Assignee: nobody → usarracini
Iteration: --- → 60.4 - Mar 12
Priority: -- → P1
Assignee | ||
Comment 1•6 years ago
|
||
When we dismiss something, of any type, it gets added to a global "block list" in your prefs. The next time we request either highlights or top sites, we filter out things that exist in that block list. So if the it's the same url for both the pocket and the bookmark, then the bookmarked site will get filtered out too. The intent here is that if you dismiss something, that means you don't want to see that that *url* and that's why it removes all things that match that url. I can look into this but it doesn't seem that high a priority
Reporter | ||
Comment 2•6 years ago
|
||
The problem here is that they have different URLs (eg https://www.wikipedia.org/ for bookmark and https://getpocket.com/a/read/44297512 for Pocket) and the bookmarked card gets dismissed with the Saved to Pocket one. And if you dismiss the bookmark first the Saved to Pocket card will remain.
Assignee | ||
Comment 3•6 years ago
|
||
They link to different urls when you click on them (different href) but internally they have the same url, which is what gets added to the list of blocked urls. If we want to fix this bug we'll have to block the pocket url instead of the actual url
Assignee | ||
Updated•6 years ago
|
Priority: P1 → P3
Updated•6 years ago
|
Iteration: 60.4 - Mar 12 → ---
Updated•6 years ago
|
Updated•6 years ago
|
Comment 4•6 years ago
|
||
This issue is still reproducible on Ubuntu, on Windows and Mac the behavior has changed, as seen in the following bug 1470211.
Assignee | ||
Comment 5•6 years ago
|
||
I'm going to close this as a dupe of 1470211, since the fix for 1470211 will also fix this one
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•