Boris Zbarsky [:bzbarsky] Assignee
	Description • 7 years ago

It can be loaded from chrome:// but we try (and fail) to load it from resource:// in some cases.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 1 • 7 years ago

MozReview-Commit-ID: BZrZMHWGN3X

	Julian Descottes [:jdescottes]
	Comment 2 • 7 years ago

I imagine that those imports might have been used when running the netmonitor/webconsole in launchpad. Launchpad is a special mode that bundles the tool as webapp that can run in a regular tab. Some of the commits that introduced those imports are about Launchpad support.

We define mappings in the webpack.config for those tools in order to rewrite chrome:// and resource:// urls (eg https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/devtools/client/netmonitor/webpack.config.js#105-127). Today however the theme files are already imported by Launchpad itself so I doubt this is still needed?

In any case, since those files were not actually loaded I think it would be better to delete the lines rather than fixing the import. In case it breaks something in Launchpad, we will use the opportunity to fix it in a less confusing way. However, I quickly tested Launchpad workflows after removing the imports and everything seems fine.

	Julian Descottes [:jdescottes]
	Comment 3 • 7 years ago

As pointed out by Nicolas, the import used in the console was not added for Launchpad support but by Bug 1326937. However, going back to the changeset where this landed, the resource:// path was already invalid.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 4 • 7 years ago

Comment on attachment 8956333 [details] [diff] [review]
Fix importing of light-theme.css to use URLs that actually exist

Review of attachment 8956333 [details] [diff] [review]:
-----------------------------------------------------------------

It sounds like Julian knows more of the history here, I'll redirect to him.

	Julian Descottes [:jdescottes]
	Comment 5 • 7 years ago

Comment on attachment 8956333 [details] [diff] [review]
Fix importing of light-theme.css to use URLs that actually exist

Review of attachment 8956333 [details] [diff] [review]:
-----------------------------------------------------------------

Could we just remove the imports? (note there's also one occurrence in https://searchfox.org/mozilla-central/source/devtools/client/shared/components/test/mochitest/test_tabs_menu.html)

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 6 • 7 years ago

MozReview-Commit-ID: BZrZMHWGN3X

	Julian Descottes [:jdescottes]
	Comment 7 • 7 years ago

Comment on attachment 8956554 [details] [diff] [review]
Stop trying to import light-theme.css from URLs that don't return anything useful

Review of attachment 8956554 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thanks for the cleanup.

	Pulsebot
	Comment 8 • 7 years ago

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a0f29000b29
Stop trying to import light-theme.css from URLs that don't return anything useful.  r=jdescottes

	Bogdan Tara[:bogdan_tara | bogdant]
	Comment 9 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/6a0f29000b29