Closed
Bug 1443600
Opened 7 years ago
Closed 7 years ago
Remove legacy Telemetry component `childPayloads`
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: chutten, Assigned: janerik)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
chutten
:
review+
|
Details | Diff | Splinter Review |
After we stop sending `childPayloads` with bug 1443599, we should remove the childPayload recording code, and any code that would display it in about:telemetry.
status-firefox60:
--- → affected
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8964949 -
Flags: review?(chutten)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jrediger
Priority: P4 → P1
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 8964949 [details] [diff] [review]
Remove legacy Telemetry component `childPayloads`
Review of attachment 8964949 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/telemetry/Histograms.json
@@ -7204,5 @@
> "high": 30,
> "n_buckets": 29,
> "description": "The size (MB) of the ping data submitted to Telemetry exceeding the maximum size"
> },
> - "TELEMETRY_DISCARDED_CONTENT_PINGS_COUNT": {
Good catch.
::: toolkit/components/telemetry/TelemetrySession.jsm
@@ -1670,5 @@
> },
>
> - sendContentProcessPing: function sendContentProcessPing(reason) {
> - this._log.trace("sendContentProcessPing - Reason " + reason);
> - const isSubsession = !this._isClassicReason(reason);
With the removal of saved-session and this, we're -this- close to removing _isClassicReason. Pretty sure we "just" need to rework how we want to deal with that one test and how we gather the current information to show in about:telemetry.
::: toolkit/content/aboutTelemetry.xhtml
@@ -125,5 @@
> </div>
> </div>
> - <div>
> - <h4 class="title">&aboutTelemetry.payloadChoiceHeader;</h4>
> - <select id="choose-payload"></select>
So happy to see this go.
Attachment #8964949 -
Flags: review?(chutten) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dfc990e1b9c
Remove legacy Telemetry component `childPayloads` r=chutten
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee | ||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•