Closed
Bug 1443608
Opened 7 years ago
Closed 7 years ago
Stop reporting legacy Telemetry component `Telemetry Experiments`
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: chutten, Assigned: janerik, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
chutten
:
review+
|
Details | Diff | Splinter Review |
Remove the reporting of Telemetry Experiments (ie, the ones overseen by the now-unused browser/experiments/Experiments.jsm module) from the Telemetry Environment, but leave normandy experiments (overseen by PreferenceExperiments.jsm) alone. Then disable any tests and update any documentation.
Reporting seems to just be in _getActiveExperiment in TelemetryEnvironment, so the simplest path may be to have that always return {}.
There are quite a few test files that use Experiments and will need changing.
We have a decent amount of documentation on Experiments that will need to be changed.
status-firefox60:
--- → affected
Reporter | ||
Updated•7 years ago
|
Mentor: chutten
Priority: -- → P3
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jrediger
Priority: P3 → P1
Assignee | ||
Comment 1•7 years ago
|
||
I disabled `_getActiveExperiment` as mentioned.
The documentation on that part was limited.
There's more experiments documentation, e.g. [1] and [2]
[1]: https://firefox-source-docs.mozilla.org/browser/experiments/experiments/index.html
[2]: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/collection/experiments.html
Am I correct that these belong to the normandy experiments?
It's not clear from the name as "normandy" is never mentioned.
Attachment #8961445 -
Flags: review?(chutten)
Reporter | ||
Comment 2•7 years ago
|
||
Comment on attachment 8961445 [details] [diff] [review]
Stop reporting legacy Telemetry component `Telemetry Experiments`
Review of attachment 8961445 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good for stopping the reporting.
This one I predict will be incredibly satisfying to rip out completely.
Attachment #8961445 -
Flags: review?(chutten) → review+
Reporter | ||
Comment 3•7 years ago
|
||
(In reply to Jan-Erik Rediger [:janerik] from comment #1)
> Created attachment 8961445 [details] [diff] [review]
> Stop reporting legacy Telemetry component `Telemetry Experiments`
>
> I disabled `_getActiveExperiment` as mentioned.
> The documentation on that part was limited.
>
> There's more experiments documentation, e.g. [1] and [2]
>
> [1]:
> https://firefox-source-docs.mozilla.org/browser/experiments/experiments/
> index.html
> [2]:
> https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/
> telemetry/collection/experiments.html
>
> Am I correct that these belong to the normandy experiments?
> It's not clear from the name as "normandy" is never mentioned.
[1] Can definitely be removed. And its child page.
[2] Must be maintained, as it's the way that others (like normandy/shield/etc) annotate the environment with a list of active experiments
Assignee | ||
Comment 4•7 years ago
|
||
Will remove the documentation in the follow-up patch then together with the code.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8480fd61e80
Stop reporting legacy Telemetry component `Telemetry Experiments`. r=chutten
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•