Closed
Bug 1443615
Opened 7 years ago
Closed 7 years ago
Remove legacy Telemetry component `TelemetryLog`
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: chutten, Assigned: janerik)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
After we stop reporting TelemetryLog in bug 1443614, we should remove it entirely.
status-firefox60:
--- → affected
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jrediger
Assignee | ||
Updated•7 years ago
|
Priority: P4 → P1
Assignee | ||
Comment 1•7 years ago
|
||
Last consumer removed in 1420908. Needs to wait for that to be merged.
Attachment #8964823 -
Flags: review?(chutten)
Reporter | ||
Comment 2•7 years ago
|
||
Comment on attachment 8964823 [details] [diff] [review]
Remove legacy Telemetry component `TelemetryLog`
Review of attachment 8964823 [details] [diff] [review]:
-----------------------------------------------------------------
I think we can also remove the TelLog renderer and the telemetry log section from about:telemetry (and then we can remove some localized strings, too). If users need to see the nothing that we record to TelemetryLog, they can use the Raw JSON link :)
Attachment #8964823 -
Flags: review?(chutten)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8964934 -
Flags: review?(chutten)
Assignee | ||
Updated•7 years ago
|
Attachment #8964823 -
Attachment is obsolete: true
Reporter | ||
Comment 4•7 years ago
|
||
Comment on attachment 8964934 [details] [diff] [review]
Remove legacy Telemetry component `TelemetryLog`
Review of attachment 8964934 [details] [diff] [review]:
-----------------------------------------------------------------
I love red patches :)
Did you poke around in about:telemetry and check the devtools log for errors? I don't think there should be, but it might be prudent to check before pushing this.
Attachment #8964934 -
Flags: review?(chutten) → review+
Assignee | ||
Comment 6•7 years ago
|
||
I thought I did poke around on about:telemetry, but I did miss one obvious section (which made the site not even load).
Removed the last mention of telemetry-log and poked around with no errors or warnings popping up.
Attachment #8965236 -
Flags: review?(chutten)
Assignee | ||
Updated•7 years ago
|
Attachment #8964934 -
Attachment is obsolete: true
Reporter | ||
Comment 7•7 years ago
|
||
Comment on attachment 8965236 [details] [diff] [review]
Remove legacy Telemetry component `TelemetryLog`
Review of attachment 8965236 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome, thank you for your diligence!
Attachment #8965236 -
Flags: review?(chutten) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 8•7 years ago
|
||
Hello, I've encountered the following error when applying this patch:
hg qpush -a
applying Bug-1443615---Remove-legacy-Telemetry-component-Te.patch
patching file toolkit/content/aboutTelemetry.js
Hunk #3 FAILED at 2443
1 out of 3 hunks FAILED -- saving rejects to file toolkit/content/aboutTelemetry.js.rej
Can you please take a look?
Flags: needinfo?(jrediger)
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 9•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8965236 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 11•7 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba89b2464447
Remove legacy Telemetry component `TelemetryLog`. r=chutten
Keywords: checkin-needed
Comment 12•7 years ago
|
||
Backed out changeset ba89b2464447 (bug 1443615) for xpcshell failures on browser/experiments/test/xpcshell/test_api.js
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ba89b2464447228f4f8c4679a78f23d84ebe1e2b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success&selectedJob=172663796
Failure log: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ba89b2464447228f4f8c4679a78f23d84ebe1e2b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success&selectedJob=172663796
Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8c6bf0af1e163ae9b78c30cc7bc823542161cc67&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success
Flags: needinfo?(jrediger)
Assignee | ||
Comment 13•7 years ago
|
||
My mistake. As noted earlier this is blocked by bug 1420908, waiting for that first.
Flags: needinfo?(jrediger)
Assignee | ||
Comment 14•7 years ago
|
||
bug 1420908 and its accompanying bug 1450801 are now merged. This one is ready for check-in now.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 15•7 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1869efdd7aa
Remove legacy Telemetry component `TelemetryLog`. r=chutten
Keywords: checkin-needed
Comment 16•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•