Closed
Bug 1443644
Opened 7 years ago
Closed 6 years ago
Add UI explaining why the "Keep until..." menu is disabled in permanent private browsing
Categories
(Firefox :: Settings UI, enhancement, P1)
Tracking
()
VERIFIED
FIXED
Firefox 66
People
(Reporter: johannh, Assigned: johannh, NeedInfo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [storage-v2])
Attachments
(1 file, 3 obsolete files)
|
(deleted),
text/x-phabricator-request
|
Details |
Screenshot
In bug 1442850 comment #8, Gijs correctly remarks that we should have an indication that the cookies and site data "keep until..." menu is disabled/overridden because of permanent private mode.
Jacqueline, do you think you can come up with something to add to our design spec? Let me know if you have any questions!
status-firefox60:
--- → affected
Flags: needinfo?(jsavory)
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jsavory
Status: NEW → ASSIGNED
Priority: -- → P1
|
|
Assignee | |
Updated•7 years ago
|
Whiteboard: [storage-v2][triage] → [storage-v2]
|
|
Assignee | |
Updated•7 years ago
|
Assignee: jsavory → jhofmann
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 2•7 years ago
|
||
So, uhm, this is the best I could come up with right now. Suggestions welcome, especially regarding the copy of course...
Attachment #8969465 -
Flags: ui-review?(jsavory)
|
|
Assignee | |
Comment 3•6 years ago
|
||
MozReview-Commit-ID: 167xaVQyQHA
|
||
Updated•6 years ago
|
Attachment #9014372 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8969465 -
Attachment is obsolete: true
Attachment #8969465 -
Flags: ui-review?(jsavory)
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8969464 -
Attachment is obsolete: true
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/408372b773e3
Add UI explaining why the "Keep until..." menu is disabled in permanent private browsing. r=ewright,flod
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Comment 7•6 years ago
|
||
The UI stating the message is present. Tests were performed on Firefox Beta 66.0b13 and latest Nightly 67.0a1 (2019-03-06) under Windows 10 (x64), Windows 7 (x64), macOS 10.12 and Ubuntu 18.04 (x64).
You need to log in
before you can comment on or make changes to this bug.
Description
•