Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th) Reporter
	Description • 6 years ago

[Notes]:
- The issue is not reproducible if the "Inspect Accessibility" option from context menu is used.

[Affected versions]:
- Nightly 60.0a1 (2018-03-01) try build 

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have the latest try build 60.0a1 from (2018-03-01) installed.
- The "Accessibility" option is checked in "Toolbar Options".

[Steps to reproduce]:
1. Open the Nightly try build with the profile from prerequisites.
2. Navigate to "https://www.wikipedia.org/ website.
3. Press the "F12" key and enable Accessibility features.
4. Click the "Accessibility picker" button.
5. Hover and click on the search bar from wikipedia page.
6. Observe the Accessibility tab.

[Expected Results]:
- The "document:" tree is extended and the the corresponding object is focused.

[Actual results]:
- The "document:" tree is not extended, therefore the corresponding object is not focused.

[Additional Notes]:
- Attached a screen recording with the issue.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 1 • 6 years ago

Thanks for filing this. Originally, the highlighter would just not show up for nodes that do not have a corresponding accessible. Such is the case with some input textarea fields that have innter markup (especially anonymous one). The right approach is to look for the first "real" accessible in the node's ancestry and return that.

	Patrick Brosset <:pbro>
	Comment 3 • 6 years ago

Comment on attachment 8958088 [details] [diff] [review]
1443831 patch

Review of attachment 8958088 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/server/actors/accessibility.js
@@ +827,5 @@
>      let target = event.originalTarget || event.target;
> +    let rawAccessible;
> +    // Find a first accessible object in the target's ancestry, including
> +    // target. Note: not all DOM nodes have corresponding accessible objects
> +    // thus we need to find one.

nit: please add an example of when this happens. Like, for which DOM node.

	Pulsebot
	Comment 4 • 6 years ago

Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da7cea91d417
accessible highlighter: when picking accessilbe for a node, walk its ancestry until the first valid accessible object. r=pbro

	Eliza Balazs [:ebalazs_]
	Comment 5 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/da7cea91d417

	Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th) Reporter
	Comment 6 • 6 years ago

I have retested this issue on the latest Nightly try build (2018-03-12) and the issue is no longer reproducible. Tested on Windows 7 x64, Mac Os 10.12 and Arch Linux.