Closed Bug 1444124 Opened 7 years ago Closed 7 years ago

[New Performance Panel] Opening perf-html.io after capturing a remote profile with WebIDE doesn't work

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: julienw, Assigned: m_kato)

References

Details

Attachments

(1 file)

STR: 1. enable the new performance panel from Devtools' Settings 2. Connect remotely to a Firefox tab on Android using WebIDE 3. Capture a profile from the new performance panel, in WebIDE Everything seems to work until we try to display the profile. Here we get an error: TypeError: browser is undefined This error happens here: https://searchfox.org/mozilla-central/rev/33cc9e0331da8d9ff3750f1e68d72d61201176cb/devtools/client/performance-new/initializer.js#29 In this bug we should find a way to get a reference back to the main browser and focus it.
Thanks for trying this out!
Priority: -- → P2
Assignee: nobody → m_kato
Comment on attachment 8958677 [details] Bug 1444124 - Open perf-html.io via browser window on WebIDE. https://reviewboard.mozilla.org/r/227598/#review233554 Thanks for the fix! Would it be possible to also fire some kind of focus event to bring the other browser into focus? It's a bit confusing from the WebIDE when the profile loads in the background.
Attachment #8958677 - Flags: review?(gtatum) → review+
(In reply to Greg Tatum [:gregtatum] [@gregtatum] from comment #4) > Comment on attachment 8958677 [details] > Bug 1444124 - Open perf-html.io via browser window on WebIDE. > > https://reviewboard.mozilla.org/r/227598/#review233554 > > Thanks for the fix! Would it be possible to also fire some kind of focus > event to bring the other browser into focus? It's a bit confusing from the > WebIDE when the profile loads in the background. OK, I will file a new bug to focus browser window.
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/aaaecd6d2062 Open perf-html.io via browser window on WebIDE. r=gregtatum
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Depends on: 1446945
> OK, I will file a new bug to focus browser window. Just a note that I filed bug 1446945 about this.
(In reply to Julien Wajsberg [:julienw] from comment #8) > > OK, I will file a new bug to focus browser window. > > Just a note that I filed bug 1446945 about this. Thanks
Blocks: 1446574
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: