Closed Bug 1444201 Opened 7 years ago Closed 4 years ago

Crash in AutoReadSegment::~AutoReadSegment via nsMsgLineStreamBuffer::ReadNextLine - logic error in nsPipe3.cpp ?

Categories

(MailNews Core :: Networking: IMAP, defect)

Product:
MailNews Core
Component:
Networking: IMAP
Platform:
Unspecified
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: wsmwk, Unassigned)

References

Details

(Keywords: crash, Whiteboard: [rare])

Crash Data

This bug was filed from the Socorro interface and is report bp-91a60d05-77de-4d6b-847a-3e5120180302. ============================================================= Top 10 frames of crashing thread: 0 XUL AutoReadSegment::~AutoReadSegment xpcom/io/nsPipe3.cpp:425 1 XUL nsPipeInputStream::ReadSegments xpcom/io/nsPipe3.cpp:416 2 XUL nsMsgLineStreamBuffer::ReadNextLine /builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/base/util/nsMsgLineBuffer.cpp:372 3 XUL nsImapProtocol::CreateNewLineFromSocket /builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/imap/src/nsImapProtocol.cpp:4797 4 XUL nsImapServerResponseParser::GetNextLineForParser /builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/imap/src/nsImapServerResponseParser.cpp:86 5 XUL nsIMAPGenericParser::AdvanceToNextLine /builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/imap/src/nsIMAPGenericParser.cpp:148 6 XUL nsImapServerResponseParser::msg_fetch_literal /builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/imap/src/nsImapServerResponseParser.cpp:3098 7 XUL nsImapServerResponseParser::msg_fetch_content /builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/imap/src/nsImapServerResponseParser.cpp:2142 8 XUL nsImapServerResponseParser::msg_fetch /builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/imap/src/nsImapServerResponseParser.cpp:1328 9 XUL nsImapServerResponseParser::response_data /builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/imap/src/nsImapServerResponseParser.cpp:701 =============================================================
Somewhat odd, that almost all the crashes of the last 8 months have been nightly builds - https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=AutoReadSegment%3A%3A~AutoReadSegment&date=%3E%3D2017-12-05T09%3A15%3A00.000Z&date=%3C2018-08-22T14%3A15%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1 bp-4517b29f-4e25-4ffa-a66d-a796c0180715 63.0a1 0 xul.dll AutoReadSegment::~AutoReadSegment() xpcom/io/nsPipe3.cpp:425 1 xul.dll nsPipeInputStream::ReadSegments(nsresult (*)(nsIInputStream*, void*, char const*, unsigned int, unsigned int, unsigned int*), void*, unsigned int, unsigned int*) xpcom/io/nsPipe3.cpp:1465 2 xul.dll nsPipeInputStream::Read(char*, unsigned int, unsigned int*) xpcom/io/nsPipe3.cpp:1473 3 xul.dll nsMsgLineStreamBuffer::ReadNextLine(nsIInputStream*, unsigned int&, bool&, nsresult*, bool) comm/mailnews/base/util/nsMsgLineBuffer.cpp:372 4 xul.dll nsImapProtocol::CreateNewLineFromSocket() comm/mailnews/imap/src/nsImapProtocol.cpp:4796 5 xul.dll nsImapServerResponseParser::GetNextLineForParser(char**) comm/mailnews/imap/src/nsImapServerResponseParser.cpp:86 6 xul.dll nsIMAPGenericParser::AdvanceToNextToken() comm/mailnews/imap/src/nsIMAPGenericParser.cpp:117

(In reply to Wayne Mery (:wsmwk) from comment #1)

Somewhat odd, that almost all the crashes of the last 8 months have been nightly builds

Still true - >75% of crashes are nightly build shttps://crash-stats.mozilla.org/signature/?product=Thunderbird&signature=AutoReadSegment%3A%3A~AutoReadSegment&date=%3E%3D2019-03-27T13%3A41%3A00.000Z&date=%3C2019-09-27T13%3A41%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#summary

For example bp-ff759c2c-070a-4370-8b1f-5515d0190912

Flags: needinfo?(jorgk)

Well, the report clearly states: MOZ_CRASH Reason (Sanitized) MOZ_DIAGNOSTIC_ASSERT(!aReadState.mActiveRead)

So some logic error in that code
https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/mozilla/xpcom/io/nsPipe3.cpp#388

Best to ask an XPCOM person.

Flags: needinfo?(jorgk)

(In reply to Jorg K (GMT+2) from comment #3)

Well, the report clearly states: MOZ_CRASH Reason (Sanitized) MOZ_DIAGNOSTIC_ASSERT(!aReadState.mActiveRead)

So some logic error in that code
https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/mozilla/xpcom/io/nsPipe3.cpp#388

Nika, can you offer some advice?

Flags: needinfo?(nika)

I'm not familiar with the logic in nsPipe3.cpp. Kris might be more familiar.

Flags: needinfo?(nika) → needinfo?(kmaglione+bmo)

Same issue as Bug 1583771 - Crash @ AutoReadSegment::AutoReadSegment ?

Summary: Crash in AutoReadSegment::~AutoReadSegment via nsMsgLineStreamBuffer::ReadNextLine → Crash in AutoReadSegment::~AutoReadSegment via nsMsgLineStreamBuffer::ReadNextLine - logic error in nsPipe3.cpp ?
Severity: critical → S3
Whiteboard: [rare]

With only two crashes in the last 3 months, both nightly, I doubt this is actionable. Unless Kris has some feedback.
bp-58349bca-f1d2-47d1-ab26-e9f850210203

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(kmaglione+bmo)
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.