Once the infrastructure from bug 1444430 is in place, we should see if we can capture profiler screenshots from BasicCompositor efficiently enough, or whether we should just disable that feature if compositing is not hardware-accelerated.

Comment on attachment 8963362 [details] Bug 1444447 - Implement AsyncReadbackBuffer Compositor APIs for BasicCompositor. https://reviewboard.mozilla.org/r/232274/#review237730 Code analysis found 2 defects in this patch: - 2 defects found by clang-tidy You can run this analysis locally with: - `./mach static-analysis check path/to/file.cpp` (C/C++) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: gfx/layers/basic/BasicCompositor.cpp:887 (Diff revision 1) > } > > +class BasicAsyncReadbackBuffer final : public AsyncReadbackBuffer > +{ > +public: > + BasicAsyncReadbackBuffer(const IntSize& aSize) Error: Bad implicit conversion constructor for 'basicasyncreadbackbuffer' [clang-tidy: mozilla-implicit-constructor] ::: gfx/layers/basic/BasicCompositor.cpp:901 (Diff revision 1) > + { > + mSurface = aSurface; > + } > + > +protected: > + ~BasicAsyncReadbackBuffer() override {} Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default] ~BasicAsyncReadbackBuffer() override {} ^ = default;

Comment on attachment 8963362 [details] Bug 1444447 - Implement AsyncReadbackBuffer Compositor APIs for BasicCompositor. https://reviewboard.mozilla.org/r/232274/#review241956 Code analysis found 2 defects in this patch: - 2 defects found by clang-tidy You can run this analysis locally with: - `./mach static-analysis check path/to/file.cpp` (C/C++) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: gfx/layers/basic/BasicCompositor.cpp:887 (Diff revision 2) > } > > +class BasicAsyncReadbackBuffer final : public AsyncReadbackBuffer > +{ > +public: > + BasicAsyncReadbackBuffer(const IntSize& aSize) Error: Bad implicit conversion constructor for 'basicasyncreadbackbuffer' [clang-tidy: mozilla-implicit-constructor] ::: gfx/layers/basic/BasicCompositor.cpp:901 (Diff revision 2) > + { > + mSurface = aSurface; > + } > + > +protected: > + ~BasicAsyncReadbackBuffer() override {} Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default] ~BasicAsyncReadbackBuffer() override {} ^ = default;

On some platforms we do not always have a DrawTarget that is the size of the entire window, so we will be unable to record the contents into screenshots in the profiler output. Now we create an additional DrawTarget that will contain the contents of the entire window so that we can record it for screenshots. This only adds the overhead of allocation while profiling and only when screenshots are requested. However, it is worth noting that since we are only capturing regions that have been invalidated, screenshots may be missing some details. For example, the initial screenshots likely won't have the browser chrome until it is re-composited, after which it will be included in future screenshots. Sections of the page will also be missing until they are composited. In both of these cases, the missing areas will appear black.

Depends on D14874

Depends on D14875

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f131cb3220edad3212c7e8a6ce9f7e0a327ea4c

Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/643f81697dae Correctly copy drawn surfaces to the full window render target in BasicCompositor r=mstange

Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/040c255450c9 Correctly copy drawn surfaces to the full window render target in BasicCompositor r=mstange