Closed Bug 1444595 Opened 7 years ago Closed 6 years ago

OOP Webextension panels on Mac: white background instead of transparency

Categories

(Core :: Graphics: WebRender, defect, P2)

60 Branch
x86
macOS
defect

Tracking

()

VERIFIED FIXED
mozilla63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox59 --- unaffected
firefox60 --- disabled
firefox61 --- disabled
firefox62 --- disabled
firefox63 --- verified
firefox64 --- verified

People

(Reporter: alberts, Assigned: sotaro)

References

Details

(Keywords: regression)

Attachments

(5 files)

Attached image browser-action-arrow-area-broken.png (deleted) —
When opening a browser action popup the area for the arrow renders in almost white - slightly transparent, breaking the UI and hiding the arrow behind it.
Alright, it seems to be Webrender, which I have turned on.
Component: WebExtensions: Frontend → Graphics: WebRender
Product: Toolkit → Core
A guess: OOP webextensions on Mac OS were enabled by bug 1385403. I don't know how it would look like with WebRender disabled. Debian Testing (KDE, Radeon RX480), main profile: If I disable my gpu-process (to not run into bug 1406230), enable extensions.webextensions.remote, such panels have a white border. Without WebRender, that thick border is black.
Blocks: 1385403
Keywords: regression
(In reply to Albert Scheiner [:alberts] from comment #1) > Alright, it seems to be Webrender, which I have turned on. 1. So it looks fine with WebRender disabled, right? 2. It also looks fine if you have WebRender enabled, but extensions.webextensions.remote set to false, right?
1. Yes and 2. Yes
Checking that this is not a blocker for enabling OOP to go to Beta and Release for OSX in 61. Webrender isn't landing until 63 and riding train with 64. This would need to be fixed before web render is pref on though.
Flags: needinfo?(milan)
Hi Jan, The testing platform in Comment 2 says Debian. We have a known graphics bug to fix with OOP on Linux that sounds related (bug 140653). "We don't support transparent popups with remote layer trees. We do support non-transparent popups with remote layer trees, so those popups appear, but with black backgrounds in place of any transparent areas." Should this bug (that includes the webrender aspect) block turning on Out of Process for webextensions on Linux (bug 1357487) instead of OOP for OSx bug (1385403)?
Flags: needinfo?(milan) → needinfo?(jan)
comment 1 assumed a WebRender regression. comment 4 confirmed that bug 1385403 just flipped extensions.webextensions.remote to true on Mac. OOP WebExtensions have a thick border on Mac and Linux when WebRender is enabled. It looks fine if WebRender is disabled. <offtopic> Linux, fresh profile: extensions.webextensions.remote;true (layers.gpu-process.enabled;true/false) = black border = apparently bug 1406533. extensions.webextensions.remote;true + gfx.webrender.all;true = white border. extensions.webextensions.remote;true + gfx.webrender.all;true + layers.gpu-process.enabled;true = Crash = bug 1406230. </offtopic>
Flags: needinfo?(jan)
The white background would be expected with extensions.webextensions.remote;true from the change in https://hg.mozilla.org/mozilla-central/rev/cb4b09616e23 I wonder what the behavior is with that reverted.
Blocks: 1365660
(In reply to Karl Tomlinson (:karlt) from comment #8) > The white background would be expected with > extensions.webextensions.remote;true from the change in > https://hg.mozilla.org/mozilla-central/rev/cb4b09616e23 > > I wonder what the behavior is with that reverted. With that reverted, we don't get remote content in the popups at all, so they have transparent areas, but are empty in the non-transparent areas.
Believe this bug is focused on issues trying to enable WebRender. Removed this bug as blocking from bug 1385403 (enabling OOP on OSx). I set this bug blocking enabling OOP on Linux (bug 1357487), because there is known issue seen in the same area (browser action popups). Any Linux fixes are potentially related or at least need cross testing (with OOP and WebRender). Steps used to see that this didn't reproduce on OSx: 1. Installed Stylus add-on on Nightly 61 2. clicked Stylus icon (and tried Personas Plus too) 3. the browser action pop-up displays fine * We did see a lot of odd behavior in this pop-up on OSx before bug 1370131 landed
Blocks: 1357487
No longer blocks: 1385403
(In reply to :shell escalante from comment #10) comment 0 is a WebRender bug report about OOP Webextensions on Mac having a fat white border (in other words: panels are itself in a non-transparent box, attachment 8957793 [details]). > Steps used to see that this didn't reproduce on OSx: Did you set gfx.webrender.all to true and restarted Nightly beforehand? Then it would be interesting to search for a fix range.
I used the next extensions: https://addons.mozilla.org/en-US/firefox/addon/styl-us/?src=search https://addons.mozilla.org/en-US/firefox/addon/groupspeeddial/?src=ss https://addons.mozilla.org/en-US/firefox/addon/https-everywhere/?src=ss https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/?src=hp-dl-mostpopular https://addons.mozilla.org/en-US/firefox/addon/adblock-plus/?src=hp-dl-mostpopular STR: Mac OS X 10.13.2 - Nightly 61.0a1 (20180419224145) 1.Flip gfx.webrender.all to true 2.Restart the browser. 3.Check if extensions.webextensions.remote is set to true. (If not, do it and restart the browser) 4.Install the extensions mentioned above. 5.Click on the browser action and observe the pop-up.
Attached image GfxTrueOOPTrue.gif (deleted) —
gfx.webrender.all - true and extensions.webextensions.remote - true - browser action has a thick border.
Attached image GfxTrueOOPFalse.gif (deleted) —
gfx.webrender.all - true and extensions.webextensions.remote - false - browser action has no white border.
Attached image GfxFalseOOPTrue.gif (deleted) —
gfx.webrender.all - false and extensions.webextensions.remote - true - browser action has no white border.
OK. Thanks. This is a separate issue from the issue on Linux, where we force the popup to be opaque. I'm not sure if this is a blocker for roll-out. It probably shouldn't be unless we plan to enable WR by default in 61.
Flags: needinfo?(sescalante)
Flags: needinfo?(kraj)
No need to panic. "the goal is to ride to beta as of 64." https://groups.google.com/forum/#!topic/mozilla.dev.tech.gfx/9mp7KYAGPRQ
(In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked) from comment #16) > OK. Thanks. This is a separate issue from the issue on Linux, where we force > the popup to be opaque. > > I'm not sure if this is a blocker for roll-out. It probably shouldn't be > unless we plan to enable WR by default in 61. Cosmin, please file a separate issue to track the issue you reported in comment 12.
Flags: needinfo?(kraj) → needinfo?(cosmin.badescu)
comment 12 just confirms comment 3 a second time (OOP Webextensions / WebRender / Mac).
(In reply to krupa raj [:krupa--use this to needinfo] from comment #18) > (In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're > blocked) from comment #16) > > OK. Thanks. This is a separate issue from the issue on Linux, where we force > > the popup to be opaque. > > > > I'm not sure if this is a blocker for roll-out. It probably shouldn't be > > unless we plan to enable WR by default in 61. > > Cosmin, please file a separate issue to track the issue you reported in > comment 12. I think we are ok with this bug, comment12 reconfirms comment3, as Jan mentioned above.
Flags: needinfo?(cosmin.badescu)
Flags: needinfo?(sescalante)
Summary: browser action popup arrow area painted white-ish → OOP Webextension panels on Mac: white background instead of transparency
Depends on: 1479680
:alberts, do you still see the problem with latest nightly?
Flags: needinfo?(albert)
Seems that bug 14799680 has fixed this. No white borders anymore with webrender enabled in 63.0a1 (2018-08-01) (64-bit) build 20180801100116
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(albert)
Resolution: --- → FIXED
Assignee: nobody → sotaro.ikeda.g
Target Milestone: --- → mozilla63
Attached video Bug1444595.mov (deleted) —
This issue is verified as fixed on Firefox 64.0a1(2018090232139) and Firefox 63.0b4(20180906162647) under Mac OS X 10.13.3. Please see the attached video.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: