This is a harder one as it has also shared files with SM.

I ifdef-ed some files to differ between TB and SM. The windows to test are: Search Messages Search Addresses Edit Virtual folders Edit Filter Edit MailViews (the Customize item in the view menuiten which can be placed on the main toolbar)

Comment on attachment 8957811 [details] [diff] [review] searchTermOverlay.patch (In reply to Richard Marti (:Paenglab) from comment #1) > The windows to test are: > Search Messages > Search Addresses > Edit Virtual folders > Edit Filter > Edit MailViews All still working, I've never heard of the last item.

Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/04e68359ee51 Replace searchTermOverlay.xul with inlining and pre-processing. r=jorgk

Comment on attachment 8957811 [details] [diff] [review] searchTermOverlay.patch Review of attachment 8957811 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for looking at this. ::: mailnews/base/search/content/searchTerm.inc @@ -37,2 @@ > > - <!-- this is what the listitems will look like: Why is the comment lost? @@ +25,3 @@ > > + </hbox> > + </vbox> Why is this /vbox here and not the parent file?

(In reply to :aceman from comment #4) > Comment on attachment 8957811 [details] [diff] [review] > searchTermOverlay.patch > > Review of attachment 8957811 [details] [diff] [review]: > ----------------------------------------------------------------- > > Thanks for looking at this. > > ::: mailnews/base/search/content/searchTerm.inc > @@ -37,2 @@ > > > > - <!-- this is what the listitems will look like: > > Why is the comment lost? Is it needed? I can add it again, when you want. > @@ +25,3 @@ > > > > + </hbox> > > + </vbox> > > Why is this /vbox here and not the parent file? Because not all files using the include had the same flex.