Closed
Bug 144469
Opened 22 years ago
Closed 22 years ago
PATCH: --enable-toolkit-qt Doesn't build with Qt 3.x
Categories
(Core Graveyard :: GFX, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: bero, Assigned: kmcclusk)
References
Details
Attachments
(1 file)
(deleted),
patch
|
hwaara
:
review+
timeless
:
superreview+
|
Details | Diff | Splinter Review |
After applying the patch from bug 144216, mozilla can be built with qt 2.x.
The patch I'm attaching to this bug report makes it build with 3.x as well.
It is currently in "It compiles, therefore it (supposedly) works" state
(meaning, no further testing) because of bug 144428.
Reporter | ||
Comment 1•22 years ago
|
||
Updated•22 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
this looks good enough for trunk
Comment 3•22 years ago
|
||
Comment on attachment 83546 [details] [diff] [review]
Fix build problems with --enable-toolkit-qt and Qt 3.x
Since there doesn't seem to be any active maintainer of the Qt port, r=hwaara.
Let's get a sr=blizzard for this and the other bustage patch, and then check it
in.
Attachment #83546 -
Flags: review+
Comment 4•22 years ago
|
||
Blizzard, please sr=/rs= this and bug 144216's patch so we can build the Qt-port
again. Thanks!
Comment 5•22 years ago
|
||
*** Bug 149220 has been marked as a duplicate of this bug. ***
Comment on attachment 83546 [details] [diff] [review]
Fix build problems with --enable-toolkit-qt and Qt 3.x
rs=blizzard
Attachment #83546 -
Flags: superreview+
Updated•22 years ago
|
Priority: -- → P3
Assignee | ||
Updated•22 years ago
|
Target Milestone: --- → Future
Comment 7•22 years ago
|
||
timeless, as this has both r= and sr=blizzard for ports code, what about
checking it in?
Comment 8•22 years ago
|
||
bug 144216 patch gives this on current trunk
patching file mozilla/gfx/src/qt/nsDeviceContextSpecQT.cpp
Hunk #2 FAILED at 20.
Hunk #3 FAILED at 36.
Hunk #4 FAILED at 60.
Hunk #5 FAILED at 294.
Hunk #6 FAILED at 304.
5 out of 6 hunks FAILED -- saving rejects to file
mozilla/gfx/src/qt/nsDeviceContextSpecQT.cpp.rej
patching file mozilla/gfx/src/qt/nsDeviceContextSpecQT.h
Hunk #3 FAILED at 41.
1 out of 3 hunks FAILED -- saving rejects to file
mozilla/gfx/src/qt/nsDeviceContextSpecQT.h.rej
can someone create an amalgamated patch for current files ?
Comment 9•22 years ago
|
||
Even if you manage to aply it, Moz won't build. There's some effort to bring
this patch up to working order, at least for QT 3.0 in the
netscape.public.mozilla.qt newsgroup.
The patch is 4½ month old. That's simply too old, it appears :-/
There's also some effort to finding a default maintainer; but this seems to
depend on getting a running QT 3.0 version, first.
Finally, I think that support for qt will be dropped in favor of qt 3.0. I, at
least, would rather have one working toolkit than two broken :o)
Comment 10•22 years ago
|
||
bero@redhat.com, i think that some of your work made it into the patch that i
committed (the changes look familiar), if that's the case I can go back and
change the cvs log to indicate that. i'm sorry it took so long to get this fixed.
I'm resolving this bug since i have built mozilla w/ qt3.0.4 and was able to
read the mozilla.org frontpage.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•