See https://developer.android.com/about/versions/oreo/android-8.0-changes.html#cwt - currently we use TYPE_PHONE. Once we start targetting Android O, we need to use TYPE_APPLICATION_OVERLAY when running on Android O or higher.

Comment on attachment 8975424 [details] Bug 1444776 - Tab Queue prompt needs to use APPLICATION_OVERLAY window type when targeting (and running on) Android O. https://reviewboard.mozilla.org/r/243714/#review249552 Seems fine, but can you confirm that the Tab Queue prompt still works with the changed window type on Android O? ::: mobile/android/base/java/org/mozilla/gecko/tabqueue/TabQueueHelper.java:82 (Diff revision 1) > View view = new View(context); > view.setVisibility(View.INVISIBLE); > > WindowManager.LayoutParams layoutParams = new WindowManager.LayoutParams( > 1, 1, > - WindowManager.LayoutParams.TYPE_PHONE, > + Build.VERSION.SDK_INT < Build.VERSION_CODES.O ? Can you please `import org.mozilla.gecko.AppConstants.Versions;` and use `Versions.feature26plus` (or add a definition for `Versions.preO`, depending which way around you'd prefer?) ::: mobile/android/base/java/org/mozilla/gecko/tabqueue/TabQueueHelper.java:83 (Diff revision 1) > view.setVisibility(View.INVISIBLE); > > WindowManager.LayoutParams layoutParams = new WindowManager.LayoutParams( > 1, 1, > - WindowManager.LayoutParams.TYPE_PHONE, > + Build.VERSION.SDK_INT < Build.VERSION_CODES.O ? > + WindowManager.LayoutParams.TYPE_PHONE : Did you actually test on a phone (or emulator) running Android O that the Tab Queue prompt still works with this change? ::: mobile/android/base/java/org/mozilla/gecko/tabqueue/TabQueueService.java:115 (Diff revision 1) > openNowButton.setText(resources.getText(R.string.tab_queue_toast_action)); > > toastLayoutParams = new WindowManager.LayoutParams( > WindowManager.LayoutParams.MATCH_PARENT, > WindowManager.LayoutParams.WRAP_CONTENT, > - WindowManager.LayoutParams.TYPE_PHONE, > + Build.VERSION.SDK_INT < Build.VERSION_CODES.O ? Ditto re AppConstants.Versions.

Comment on attachment 8975424 [details] Bug 1444776 - Tab Queue prompt needs to use APPLICATION_OVERLAY window type when targeting (and running on) Android O. I also tested, this is the result - attachment 8975459 [details]

Also if you actually enable "Permit drawing over other apps", so you get the actual Tab Queue toast itself?

This is tested on Oreo device with the TYPE_APPLICATION_OVERLAY flag - attachment 8975773 [details]

Comment on attachment 8975424 [details] Bug 1444776 - Tab Queue prompt needs to use APPLICATION_OVERLAY window type when targeting (and running on) Android O. https://reviewboard.mozilla.org/r/243714/#review250042 ::: mobile/android/base/java/org/mozilla/gecko/tabqueue/TabQueueHelper.java:24 (Diff revision 2) > import android.content.Context; > import android.content.Intent; > import android.content.SharedPreferences; > import android.content.res.Resources; > import android.graphics.PixelFormat; > +import android.os.Build; Nit: That import is no longer required.

(In reply to Andrei Lazar from comment #8) > This is tested on Oreo device with the TYPE_APPLICATION_OVERLAY flag - > attachment 8975773 [details] Thanks - now if only all compatibility changes could be as easy as that...

Susheel, can you please help us land this?

Pushed by michael.l.comella@gmail.com: https://hg.mozilla.org/integration/autoland/rev/29becdf09eb6 Tab Queue prompt needs to use APPLICATION_OVERLAY window type when targeting (and running on) Android O. r=JanH

Backout by aiakab@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15c30a777a2d Backed out changeset 29becdf09eb6 for lint bustage on Android

Backed out changeset 29becdf09eb6 (bug 1444776) for lint bustage on Android. Backout revision https://hg.mozilla.org/integration/autoland/rev/15c30a777a2dd6916df47f94d2070c5d5ea2bd12 Failing push https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=29becdf09eb609a56d84a2a96c99e8352f94dfed&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified Link to failure log https://treeherder.mozilla.org/logviewer.html#?job_id=180961591&repo=autoland Part of that log:[task 2018-05-30T18:25:54.960Z] 18:25:54 INFO - Using env: (same as previous command) [task 2018-05-30T18:25:55.163Z] 18:25:55 INFO - /builds/worker/workspace/build/src/android-gradle-dependencies/gradle-dist/bin/gradle --console=plain app:lintOfficialWithoutGeckoBinariesNoMinApiPhotonDebug --continue [task 2018-05-30T18:25:55.174Z] 18:25:55 INFO - Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf-8 [task 2018-05-30T18:25:55.554Z] 18:25:55 INFO - To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/4.1/userguide/gradle_daemon.html. [task 2018-05-30T18:25:56.319Z] 18:25:56 INFO - Daemon will be stopped at the end of the build stopping after processing [task 2018-05-30T18:25:57.724Z] 18:25:57 INFO - Parallel execution is an incubating feature. [task 2018-05-30T18:26:03.865Z] 18:26:03 INFO - :generateCodeAndResources [task 2018-05-30T18:26:03.865Z] 18:26:03 INFO - :app:preBuild [task 2018-05-30T18:26:03.865Z] 18:26:03 INFO - :geckoview:preBuild [task 2018-05-30T18:26:03.865Z] 18:26:03 INFO - :thirdparty:preBuild [task 2018-05-30T18:26:03.866Z] 18:26:03 INFO - :geckoview:preBuild UP-TO-DATE [task 2018-05-30T18:26:03.875Z] 18:26:03 INFO - :app:preBuild UP-TO-DATE [task 2018-05-30T18:26:03.875Z] 18:26:03 INFO - :thirdparty:preBuild UP-TO-DATE [task 2018-05-30T18:26:03.875Z] 18:26:03 INFO - :app:extractProguardFiles [task 2018-05-30T18:26:03.875Z] 18:26:03 INFO - :geckoview:preOfficialWithoutGeckoBinariesNoMinApiDebugBuild UP-TO-DATE [task 2018-05-30T18:26:03.875Z] 18:26:03 INFO - :thirdparty:preDebugBuild UP-TO-DATE [task 2018-05-30T18:26:03.875Z] 18:26:03 INFO - :geckoview:checkOfficialWithoutGeckoBinariesNoMinApiDebugManifest [task 2018-05-30T18:26:03.906Z] 18:26:03 INFO - :thirdparty:checkDebugManifest UP-TO-DATE [task 2018-05-30T18:26:03.906Z] 18:26:03 INFO - :geckoview:checkOfficialWithoutGeckoBinariesNoMinApiDebugManifest UP-TO-DATE [task 2018-05-30T18:26:03.907Z] 18:26:03 INFO - :app:extractProguardFiles UP-TO-DATE [task 2018-05-30T18:26:03.907Z] 18:26:03 INFO - :thirdparty:processDebugManifest [task 2018-05-30T18:26:03.907Z] 18:26:03 INFO - :app:prepareLintJar [task 2018-05-30T18:26:03.907Z] 18:26:03 INFO - :geckoview:processOfficialWithoutGeckoBinariesNoMinApiDebugManifest [task 2018-05-30T18:26:03.907Z] 18:26:03 INFO - :app:prepareLintJar UP-TO-DATE [task 2018-05-30T18:26:03.915Z] 18:26:03 INFO - :app:generateOfficialWithoutGeckoBinariesNoMinApiPhotonDebugResValues UP-TO-DATE [task 2018-05-30T18:26:03.915Z] 18:26:03 INFO - :app:syncPreprocessedResForOfficialWithoutGeckoBinariesNoMinApiPhotonDebug [task 2018-05-30T18:26:03.915Z] 18:26:03 INFO - :geckoview:processOfficialWithoutGeckoBinariesNoMinApiDebugManifest UP-TO-DATE [task 2018-05-30T18:26:03.915Z] 18:26:03 INFO - :thirdparty:processDebugManifest UP-TO-DATE [task 2018-05-30T18:26:03.926Z] 18:26:03 INFO - :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugAidl [task 2018-05-30T18:26:03.926Z] 18:26:03 INFO - :thirdparty:compileDebugAidl [task 2018-05-30T18:26:03.927Z] 18:26:03 INFO - :app:syncPreprocessedResForOfficialWithoutGeckoBinariesNoMinApiPhotonDebug UP-TO-DATE [task 2018-05-30T18:26:03.946Z] 18:26:03 INFO - :app:createOfficialWithoutGeckoBinariesNoMinApiPhotonDebugCompatibleScreenManifests UP-TO-DATE [task 2018-05-30T18:26:03.947Z] 18:26:03 INFO - :thirdparty:compileDebugAidl UP-TO-DATE [task 2018-05-30T18:26:03.950Z] 18:26:03 INFO - :app:rewriteManifestPackageForOfficialWithoutGeckoBinariesNoMinApiPhotonDebug [task 2018-05-30T18:26:03.950Z] 18:26:03 INFO - :thirdparty:packageDebugRenderscript NO-SOURCE [task 2018-05-30T18:26:03.950Z] 18:26:03 INFO - :thirdparty:compileDebugRenderscript [task 2018-05-30T18:26:03.951Z] 18:26:03 INFO - :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugAidl UP-TO-DATE [task 2018-05-30T18:26:03.951Z] 18:26:03 INFO - :geckoview:packageOfficialWithoutGeckoBinariesNoMinApiDebugRenderscript [task 2018-05-30T18:26:03.951Z] 18:26:03 INFO - :app:rewriteManifestPackageForOfficialWithoutGeckoBinariesNoMinApiPhotonDebug UP-TO-DATE [task 2018-05-30T18:26:03.990Z] 18:26:03 INFO - :app:preOfficialWithoutGeckoBinariesNoMinApiPhotonDebugBuild [task 2018-05-30T18:26:03.990Z] 18:26:03 INFO - :geckoview:packageOfficialWithoutGeckoBinariesNoMinApiDebugRenderscript NO-SOURCE [task 2018-05-30T18:26:03.990Z] 18:26:03 INFO - :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugRenderscript [task 2018-05-30T18:26:03.990Z] 18:26:03 INFO - :thirdparty:compileDebugRenderscript UP-TO-DATE [task 2018-05-30T18:26:03.990Z] 18:26:03 INFO - :thirdparty:generateDebugResValues UP-TO-DATE [task 2018-05-30T18:26:03.990Z] 18:26:03 INFO - :thirdparty:generateDebugResources UP-TO-DATE [task 2018-05-30T18:26:03.991Z] 18:26:03 INFO - :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugRenderscript UP-TO-DATE [task 2018-05-30T18:26:03.991Z] 18:26:03 INFO - :thirdparty:packageDebugResources [task 2018-05-30T18:26:03.991Z] 18:26:03 INFO - :geckoview:generateOfficialWithoutGeckoBinariesNoMinApiDebugResValues UP-TO-DATE [task 2018-05-30T18:26:03.992Z] 18:26:03 INFO - :geckoview:generateOfficialWithoutGeckoBinariesNoMinApiDebugResources UP-TO-DATE [task 2018-05-30T18:26:03.993Z] 18:26:03 INFO - :geckoview:packageOfficialWithoutGeckoBinariesNoMinApiDebugResources [task 2018-05-30T18:26:03.993Z] 18:26:03 INFO - :thirdparty:packageDebugResources UP-TO-DATE [task 2018-05-30T18:26:03.993Z] 18:26:03 INFO - :thirdparty:platformAttrExtractor UP-TO-DATE [task 2018-05-30T18:26:03.993Z] 18:26:03 INFO - :thirdparty:processDebugResources [task 2018-05-30T18:26:03.993Z] 18:26:03 INFO - :geckoview:packageOfficialWithoutGeckoBinariesNoMinApiDebugResources UP-TO-DATE [task 2018-05-30T18:26:04.026Z] 18:26:04 INFO - :geckoview:platformAttrExtractor UP-TO-DATE [task 2018-05-30T18:26:04.118Z] 18:26:04 INFO - :geckoview:processOfficialWithoutGeckoBinariesNoMinApiDebugResources [task 2018-05-30T18:26:04.119Z] 18:26:04 INFO - :thirdparty:processDebugResources UP-TO-DATE [task 2018-05-30T18:26:04.130Z] 18:26:04 INFO - :thirdparty:generateDebugBuildConfig UP-TO-DATE [task 2018-05-30T18:26:04.130Z] 18:26:04 INFO - :thirdparty:prepareLintJar [task 2018-05-30T18:26:04.131Z] 18:26:04 INFO - :geckoview:processOfficialWithoutGeckoBinariesNoMinApiDebugResources UP-TO-DATE [task 2018-05-30T18:26:04.131Z] 18:26:04 INFO - :geckoview:generateOfficialWithoutGeckoBinariesNoMinApiDebugBuildConfig UP-TO-DATE [task 2018-05-30T18:26:04.139Z] 18:26:04 INFO - :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugKotlin [task 2018-05-30T18:26:04.140Z] 18:26:04 INFO - :thirdparty:prepareLintJar UP-TO-DATE [task 2018-05-30T18:26:04.140Z] 18:26:04 INFO - :thirdparty:generateDebugSources UP-TO-DATE [task 2018-05-30T18:26:04.141Z] 18:26:04 INFO - :thirdparty:javaPreCompileDebug UP-TO-DATE [task 2018-05-30T18:26:04.151Z] 18:26:04 INFO - :thirdparty:compileDebugJavaWithJavac [task 2018-05-30T18:26:04.152Z] 18:26:04 INFO - :app:preOfficialWithoutGeckoBinariesNoMinApiPhotonDebugBuild UP-TO-DATE [task 2018-05-30T18:26:04.162Z] 18:26:04 INFO - :app:compileOfficialWithoutGeckoBinariesNoMinApiPhotonDebugAidl UP-TO-DATE [task 2018-05-30T18:26:04.173Z] 18:26:04 INFO - :app:compileOfficialWithoutGeckoBinariesNoMinApiPhotonDebugRenderscript UP-TO-DATE [task 2018-05-30T18:26:04.173Z] 18:26:04 INFO - :app:checkOfficialWithoutGeckoBinariesNoMinApiPhotonDebugManifest UP-TO-DATE [task 2018-05-30T18:26:04.254Z] 18:26:04 INFO - :app:generateOfficialWithoutGeckoBinariesNoMinApiPhotonDebugBuildConfig UP-TO-DATE [task 2018-05-30T18:26:04.254Z] 18:26:04 INFO - :app:generateOfficialWithoutGeckoBinariesNoMinApiPhotonDebugResources UP-TO-DATE [task 2018-05-30T18:26:04.409Z] 18:26:04 INFO - :app:mergeOfficialWithoutGeckoBinariesNoMinApiPhotonDebugResources [task 2018-05-30T18:26:04.410Z] 18:26:04 INFO - :thirdparty:compileDebugJavaWithJavac UP-TO-DATE [task 2018-05-30T18:26:04.410Z] 18:26:04 INFO - :thirdparty:processDebugJavaRes NO-SOURCE [task 2018-05-30T18:26:04.429Z] 18:26:04 INFO - :thirdparty:transformClassesAndResourcesWithPrepareIntermediateJarsForDebug UP-TO-DATE [task 2018-05-30T18:26:04.767Z] 18:26:04 INFO - :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugKotlin UP-TO-DATE [task 2018-05-30T18:26:04.767Z] 18:26:04 INFO - :geckoview:prepareLintJar UP-TO-DATE [task 2018-05-30T18:26:04.767Z] 18:26:04 INFO - :geckoview:generateOfficialWithoutGeckoBinariesNoMinApiDebugSources UP-TO-DATE [task 2018-05-30T18:26:04.776Z] 18:26:04 INFO - :geckoview:javaPreCompileOfficialWithoutGeckoBinariesNoMinApiDebug UP-TO-DATE [task 2018-05-30T18:26:04.806Z] 18:26:04 INFO - :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugJavaWithJavac [task 2018-05-30T18:26:04.806Z] 18:26:04 INFO - :app:mergeOfficialWithoutGeckoBinariesNoMinApiPhotonDebugResources UP-TO-DATE [task 2018-05-30T18:26:04.817Z] 18:26:04 INFO - :app:processOfficialWithoutGeckoBinariesNoMinApiPhotonDebugManifest UP-TO-DATE [task 2018-05-30T18:26:04.827Z] 18:26:04 INFO - :app:splitsDiscoveryTaskOfficialWithoutGeckoBinariesNoMinApiPhotonDebug UP-TO-DATE [task 2018-05-30T18:26:04.848Z] 18:26:04 INFO - :app:processOfficialWithoutGeckoBinariesNoMinApiPhotonDebugResources UP-TO-DATE [task 2018-05-30T18:26:04.848Z] 18:26:04 INFO - :app:syncPreprocessedJavaForOfficialWithoutGeckoBinariesNoMinApiPhotonDebug UP-TO-DATE [task 2018-05-30T18:26:04.848Z] 18:26:04 INFO - :app:generateOfficialWithoutGeckoBinariesNoMinApiPhotonDebugSources UP-TO-DATE [task 2018-05-30T18:26:04.879Z] 18:26:04 INFO - :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugJavaWithJavac UP-TO-DATE [task 2018-05-30T18:26:04.879Z] 18:26:04 INFO - :geckoview:processOfficialWithoutGeckoBinariesNoMinApiDebugJavaRes NO-SOURCE [task 2018-05-30T18:26:04.888Z] 18:26:04 INFO - :geckoview:transformClassesAndResourcesWithPrepareIntermediateJarsForOfficialWithoutGeckoBinariesNoMinApiDebug UP-TO-DATE [task 2018-05-30T18:26:04.899Z] 18:26:04 INFO - :app:javaPreCompileOfficialWithoutGeckoBinariesNoMinApiPhotonDebug UP-TO-DATE [task 2018-05-30T18:26:05.118Z] 18:26:05 INFO - :app:compileOfficialWithoutGeckoBinariesNoMinApiPhotonDebugJavaWithJavac UP-TO-DATE [task 2018-05-30T18:26:37.059Z] 18:26:37 INFO - :app:lintOfficialWithoutGeckoBinariesNoMinApiPhotonDebug [task 2018-05-30T18:26:37.059Z] 18:26:37 INFO - Wrote HTML report to file:///builds/worker/workspace/build/src/obj-firefox/gradle/build/mobile/android/app/reports/lint-results-officialWithoutGeckoBinariesNoMinApiPhotonDebug.html [task 2018-05-30T18:26:37.080Z] 18:26:37 INFO - Wrote XML report to file:///builds/worker/workspace/build/src/obj-firefox/gradle/build/mobile/android/app/reports/lint-results-officialWithoutGeckoBinariesNoMinApiPhotonDebug.xml [task 2018-05-30T18:26:37.080Z] 18:26:37 INFO - Lint found 6 errors, 439 warnings [task 2018-05-30T18:26:37.080Z] 18:26:37 INFO - :app:lintOfficialWithoutGeckoBinariesNoMinApiPhotonDebug FAILED [task 2018-05-30T18:26:37.090Z] 18:26:37 INFO - FAILURE: Build failed with an exception. [task 2018-05-30T18:26:37.090Z] 18:26:37 INFO - * What went wrong: [task 2018-05-30T18:26:37.090Z] 18:26:37 INFO - Execution failed for task ':app:lintOfficialWithoutGeckoBinariesNoMinApiPhotonDebug'. [task 2018-05-30T18:26:37.091Z] 18:26:37 INFO - > Lint found errors in the project; aborting build. [task 2018-05-30T18:26:37.092Z] 18:26:37 INFO - Fix the issues identified by lint, or add the following to your build script to proceed with errors: [task 2018-05-30T18:26:37.092Z] 18:26:37 INFO - ... [task 2018-05-30T18:26:37.092Z] 18:26:37 INFO - android { [task 2018-05-30T18:26:37.092Z] 18:26:37 INFO - lintOptions { [task 2018-05-30T18:26:37.094Z] 18:26:37 INFO - abortOnError false [task 2018-05-30T18:26:37.094Z] 18:26:37 INFO - } [task 2018-05-30T18:26:37.094Z] 18:26:37 INFO - } [task 2018-05-30T18:26:37.095Z] 18:26:37 INFO - ... [task 2018-05-30T18:26:37.096Z] 18:26:37 INFO - * Try: [task 2018-05-30T18:26:37.096Z] 18:26:37 INFO - Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. [task 2018-05-30T18:26:37.096Z] 18:26:37 INFO - * Get more help at https://help.gradle.org [task 2018-05-30T18:26:37.097Z] 18:26:37 INFO - BUILD FAILED in 41s [task 2018-05-30T18:26:37.097Z] 18:26:37 INFO - 47 actionable tasks: 2 executed, 45 up-to-date [task 2018-05-30T18:26:37.792Z] 18:26:37 INFO - TinderboxPrint: report<br/><a href="https://queue.taskcluster.net/v1/task/Zh4L8TNCQ8GO1yCskEfuGw/runs/0/artifacts/public/android/lint/lint-results-officialWithoutGeckoBinariesNoMinApiPhotonDebug.html">HTML officialWithoutGeckoBinariesNoMinApiPhotonDebug report</a>, visit "Inspect Task" link for details [task 2018-05-30T18:26:37.792Z] 18:26:37 INFO - TinderboxPrint: report<br/><a href="https://queue.taskcluster.net/v1/task/Zh4L8TNCQ8GO1yCskEfuGw/runs/0/artifacts/public/android/lint/lint-results-officialWithoutGeckoBinariesNoMinApiPhotonDebug.xml">XML officialWithoutGeckoBinariesNoMinApiPhotonDebug report</a>, visit "Inspect Task" link for details [task 2018-05-30T18:26:37.793Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | android-lint | Lint found errors in the project; aborting build. See the report at: https://queue.taskcluster.net/v1/task/Zh4L8TNCQ8GO1yCskEfuGw/runs/0/artifacts/public/android/lint/lint-results-officialWithoutGeckoBinariesNoMinApiPhotonDebug.html [task 2018-05-30T18:26:37.793Z] 18:26:37 INFO - SUITE-START | android-lint | officialWithoutGeckoBinariesNoMinApiPhotonDebug [task 2018-05-30T18:26:37.793Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <issue category="Performance" explanation="Unused resources make applications larger and slow down builds." id="UnusedResources" message="The resource `R.drawable.firstrun_tabqueue_off` appears to be unused" priority="3" quickfix="studio" severity="Error" summary="Unused resources"> [task 2018-05-30T18:26:37.794Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <location file="/builds/worker/workspace/build/src/mobile/android/app/src/main/res/drawable-nodpi/firstrun_tabqueue_off.png" /> [task 2018-05-30T18:26:37.794Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | </issue> [task 2018-05-30T18:26:37.794Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <issue category="Performance" explanation="Unused resources make applications larger and slow down builds." id="UnusedResources" message="The resource `R.drawable.firstrun_tabqueue_on` appears to be unused" priority="3" quickfix="studio" severity="Error" summary="Unused resources"> [task 2018-05-30T18:26:37.794Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <location file="/builds/worker/workspace/build/src/mobile/android/app/src/main/res/drawable-nodpi/firstrun_tabqueue_on.webp" /> [task 2018-05-30T18:26:37.795Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | </issue> [task 2018-05-30T18:26:37.795Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <issue category="Performance" errorLine1=" &lt;string name=&quot;firstrun_tabqueue_message_off&quot;&gt;Turn on Tab queue&lt;/string&gt;" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" explanation="Unused resources make applications larger and slow down builds." id="UnusedResources" message="The resource `R.string.firstrun_tabqueue_message_off` appears to be unused" priority="3" quickfix="studio" severity="Error" summary="Unused resources"> [task 2018-05-30T18:26:37.795Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <location column="11" file="/builds/worker/workspace/build/src/obj-firefox/gradle/build/mobile/android/app/moz.build/src/officialWithoutGeckoBinariesNoMinApiPhotonDebug/res/values/strings.xml" line="76" /> [task 2018-05-30T18:26:37.796Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | </issue> [task 2018-05-30T18:26:37.796Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <issue category="Performance" errorLine1=" &lt;string name=&quot;firstrun_tabqueue_subtext_off&quot;&gt;Save links for later in Nightly when tapping them in other apps.&lt;/string&gt;" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" explanation="Unused resources make applications larger and slow down builds." id="UnusedResources" message="The resource `R.string.firstrun_tabqueue_subtext_off` appears to be unused" priority="3" quickfix="studio" severity="Error" summary="Unused resources"> [task 2018-05-30T18:26:37.796Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <location column="11" file="/builds/worker/workspace/build/src/obj-firefox/gradle/build/mobile/android/app/moz.build/src/officialWithoutGeckoBinariesNoMinApiPhotonDebug/res/values/strings.xml" line="77" /> [task 2018-05-30T18:26:37.796Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | </issue> [task 2018-05-30T18:26:37.797Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <issue category="Performance" errorLine1=" &lt;string name=&quot;firstrun_tabqueue_message_on&quot;&gt;Success!&lt;/string&gt;" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" explanation="Unused resources make applications larger and slow down builds." id="UnusedResources" message="The resource `R.string.firstrun_tabqueue_message_on` appears to be unused" priority="3" quickfix="studio" severity="Error" summary="Unused resources"> [task 2018-05-30T18:26:37.797Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <location column="11" file="/builds/worker/workspace/build/src/obj-firefox/gradle/build/mobile/android/app/moz.build/src/officialWithoutGeckoBinariesNoMinApiPhotonDebug/res/values/strings.xml" line="78" /> [task 2018-05-30T18:26:37.797Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | </issue> [task 2018-05-30T18:26:37.798Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <issue category="Performance" errorLine1=" &lt;string name=&quot;firstrun_tabqueue_subtext_on&quot;&gt;You can always turn this off in Settings under General.&lt;/string&gt;" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" explanation="Unused resources make applications larger and slow down builds." id="UnusedResources" message="The resource `R.string.firstrun_tabqueue_subtext_on` appears to be unused" priority="3" quickfix="studio" severity="Error" summary="Unused resources"> [task 2018-05-30T18:26:37.798Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | <location column="11" file="/builds/worker/workspace/build/src/obj-firefox/gradle/build/mobile/android/app/moz.build/src/officialWithoutGeckoBinariesNoMinApiPhotonDebug/res/values/strings.xml" line="79" /> [task 2018-05-30T18:26:37.798Z] 18:26:37 INFO - TEST-UNEXPECTED-FAIL | </issue> [task 2018-05-30T18:26:37.798Z] 18:26:37 INFO - SUITE-END | android-lint | officialWithoutGeckoBinariesNoMinApiPhotonDebug [task 2018-05-30T18:26:37.806Z] 18:26:37 ERROR - Return code: 1 [task 2018-05-30T18:26:37.807Z] 18:26:37 ERROR - 1 not in success codes: [0] [task 2018-05-30T18:26:37.807Z] 18:26:37 WARNING - setting return code to 2 [task 2018-05-30T18:26:37.807Z] 18:26:37 FATAL - Halting on failure while running ['/usr/bin/python2.7', 'mach', '--log-no-times', 'android', 'lint'] [task 2018-05-30T18:26:37.807Z] 18:26:37 FATAL - Running post_fatal callback... [task 2018-05-30T18:26:37.808Z] 18:26:37 FATAL - Exiting 2 [task 2018-05-30T18:26:37.808Z] 18:26:37 INFO - [mozharness: 2018-05-30 18:26:37.808192Z] Finished build step (failed) [task 2018-05-30T18:26:37.808Z] 18:26:37 INFO - Running post-run listener: _summarize [task 2018-05-30T18:26:37.808Z] 18:26:37 ERROR - # TBPL FAILURE #

This was backed out, NI Andrei to get it back in.

Removed some unused resources (drawables and strings), now it should pass. Jan, can you please confirm this?

You can either push it to Try and add "android-lint" as a build target (see https://treeherder.mozilla.org/#/jobs?repo=try&revision=434ecba1029a8e378a2cea7cc3458688a6d3b370), or running ./mach android lint locally should work as well.

I've updated my patch as per comment 16, the changes have passed lint inspection as per (https://treeherder.mozilla.org/#/jobs?repo=try&revision=434ecba1029a8e378a2cea7cc3458688a6d3b370), please help push this. Thank you!

Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6379a0ea5323 Tab Queue prompt needs to use APPLICATION_OVERLAY window type when targeting (and running on) Android O. r=JanH

Devices: - Samsung Galaxy Note 8 (Android 8.0.0) - Google Pixel (Android 8.1.0) Tested in the latest beta (62.0b3), tab queue overlay works as expected. Marking as verified.