Closed Bug 1444798 Opened 7 years ago Closed 7 years ago

Images don't render (Win10 x86)

Categories

(Core :: Graphics: WebRender, defect)

x86
Windows
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- disabled
firefox61 --- verified
firefox62 --- verified

People

(Reporter: kocoreluka, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

(Keywords: nightly-community, regression)

Attachments

(3 files, 1 obsolete file)

Attached image 15614554.png (deleted) —
User Agent: Mozilla/5.0 (Windows NT 10.0; rv:60.0) Gecko/20100101 Firefox/60.0 Build ID: 20180311100058 Steps to reproduce: I enabled webrender in Nightly (60.0a1). Actual results: Images don't render on any site, this just happens in Nightly 60.0a1 because in Nightly 59 (and older versions) this never happened. I have already disabled all my add-ons and un-doing all my userchrome customizations (all my drivers are updated) but I still have the same problem. Expected results: Maybe it's an incompatibility with my computer or something like that with the newest versions. If this help I am using Windows 10 Pro (32 bits), my processor it's an Intel Pentium G630, I am using the integrated graphics.
Component: Untriaged → Graphics: WebRender
OS: Unspecified → Windows 10
Product: Firefox → Core
Hardware: Unspecified → x86_64
Version: 60 Branch → Trunk
Could you please re-enable WebRender (and restart Nightly), then open about:support, click on the "Copy text to clipboard" button, paste it into a text file and upload it here (Attach File)? Thanks!
Hardware: x86_64 → x86
Attached file Text from about:support (deleted) —
(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #1) > Could you please re-enable WebRender (and restart Nightly), then open > about:support, click on the "Copy text to clipboard" button, paste it into a > text file and upload it here (Attach File)? Thanks! Done.
> Workarounds > NO_CONSTANT_BUFFER_OFFSETTING: Constant buffer offset binding does not work > Failure Log > (#0): GP+[GFX1-]: Failed to lock ExternalImage for extId:163312040 > (#35): GP+[GFX1-]: Failed to lock ExternalImage for extId:163312040 > (#36): GP+[GFX1-]: Failed to lock ExternalImage for extId:163312040 ----- Would everything look fine if you set the following and restart Nightly afterwards? gfx.webrender.all;true gfx.webrender.force-angle;false
Summary: Images don't render while i use webrender. → Images don't render (Intel/Win10 x86)
(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #4) > > Workarounds > > NO_CONSTANT_BUFFER_OFFSETTING: Constant buffer offset binding does not work > > Failure Log > > (#0): GP+[GFX1-]: Failed to lock ExternalImage for extId:163312040 > > (#35): GP+[GFX1-]: Failed to lock ExternalImage for extId:163312040 > > (#36): GP+[GFX1-]: Failed to lock ExternalImage for extId:163312040 > > ----- > > Would everything look fine if you set the following and restart Nightly > afterwards? > gfx.webrender.all;true > gfx.webrender.force-angle;false Now everything looks alright again! nice.
Summary: Images don't render (Intel/Win10 x86) → Images don't render (ANGLE @ Intel/Win10 x86)
Win10 x64, Radeon RX480 64 bit is fine, 32 bit is bad. mozregression --good 2018-02-15 --bad 2018-03-12 --bits 32 --pref gfx.webrender.all:true > 7:03.76 INFO: Last good revision: c1b8f65ad2ed30ad5626589c8edcdead87980108 > 7:03.76 INFO: First bad revision: 19f8463d3f9d74bfd5ab9f20a38de37107bd726a > 7:03.76 INFO: Pushlog: > https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c1b8f65ad2ed30ad5626589c8edcdead87980108&tochange=19f8463d3f9d74bfd5ab9f20a38de37107bd726a > 19f8463d3f9d Ralph Giles — Bug 1430885 - Update builders to rust 1.24.0. r=froydnj
Blocks: 1430885
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Ever confirmed: true
Keywords: regression
Summary: Images don't render (ANGLE @ Intel/Win10 x86) → Images don't render (ANGLE x86)
(In reply to Jul from comment #5) > Now everything looks alright again! nice. Strange. Not for me. mozregression --repo autoland --launch c1b8f65ad2ed30ad5626589c8edcdead87980108 --bits 32 --pref gfx.webrender.all:true gfx.webrender.force-angle:false good (only bug 1432261) mozregression --repo autoland --launch 19f8463d3f9d74bfd5ab9f20a38de37107bd726a --bits 32 --pref gfx.webrender.all:true gfx.webrender.force-angle:false bad
Summary: Images don't render (ANGLE x86) → Images don't render (Win10 x86)
gfx.webrender.force-angle=false reverts to Direct3D 11 (Advanced Layers) and throws this error GP+[GFX1-]: Failed GL context creation for WebRender: 00000000
Flags: needinfo?(jan)
Missed* So Comment 5 fix is not correct
<offtopic> 32 bit WebRender seems to be completely broken on my 64 bit Debian, even before this regression. Debian Testing x64 (KDE, Radeon RX480) To install missing dependencies: apt-get install firefox-esr:i386 libgl1-mesa-glx:i386 libpulse0:i386 mozregression --launch 2018-02-10 --bits 32 --pref layers.acceleration.force-enabled:true plugin.disable:true -B debug good, OpenGL compositing is used mozregression --launch 2018-02-10 --bits 32 --pref gfx.webrender.all:true plugin.disable:true -B debug crash, won't start </offtopic>
Flags: needinfo?(jan)
I also saw the same problem on x86 Win7.
When I set the following to mozconfig, I could reproduce the same problem with my local build on 64bit Win10. > ac_add_options --target=i686-w64-mingw32 > ac_add_options --host=i686-w64-mingw32 external image id in rust and in LockExternalImage() in c were different. From it, ffi might be incompatible on 32bit win build.
Blocks: wr-stability
OS: Windows 10 → Windows
Attached patch patch - Fix ExternalImageCallback func types (obsolete) (deleted) — Splinter Review
Assignee: nobody → sotaro.ikeda.g
ExternalImageCallback implementations are in C, but their definition does not have 'extern "C"'.
Attachment #8959084 - Attachment is obsolete: true
(In reply to Sotaro Ikeda [:sotaro] from comment #16) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d6e4ec9a717db1fb7be43e502da8fcaea10a8d8 Win10 x64, Radeon RX480 mozregression --launch 2018-03-15 --bits 32 --pref gfx.webrender.all:true bad mozregression --repo try --launch 6d6e4ec9a717db1fb7be43e502da8fcaea10a8d8 --bits 32 --pref gfx.webrender.all:true good (no failures) mozregression --repo try --launch 6d6e4ec9a717db1fb7be43e502da8fcaea10a8d8 --bits 32 --pref gfx.webrender.all:true gfx.webrender.force-angle:false good (only bug 1432261) (Linux64 and Win64 also looked fine.)
(In reply to Sotaro Ikeda [:sotaro] from comment #16) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=6d6e4ec9a717db1fb7be43e502da8fcaea10a8d8 With 32bit build, I confirmed that the problem was addressed on my 32bit Win7 PC.
Attachment #8959088 - Flags: review?(jmuizelaar)
Attachment #8959088 - Flags: review?(jmuizelaar) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ddd0ebbbe277 Fix ExternalImageCallback func types r=jrmuizel
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Flags: qe-verify+
I managed to reproduce the bug using an older version of Nightly (2018-03-11) on Windows 10 x32. I retested everything on latest Nightly 62.0a1 and beta 61.0b6 using Windows 10 x32, Windows 7 x32, Windows 8.1 x32 and Ubuntu 16.04 x32. The bug is not reproducing anymore.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: