Closed Bug 1444893 Opened 7 years ago Closed 6 years ago

Android Gecko Profiler captures have to be symbolicated manually

Categories

(Core :: Gecko Profiler, defect, P1)

58 Branch
Unspecified
Android
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jesup, Unassigned)

References

(Blocks 1 open bug)

Details

snorp has a script for symbolicating android profiler captures, though it ran my 32GB linux box out of ram and 16GB swap for about 20 minutes before finishing, effectively locking my machine. The symbolicate script can be found in the (no longer usable) extension source here: https://github.com/snorp/fennec-profiler-addon.git I understand there's work planned to move symbolicating to perf-html.io. My only concern is that it needs to support symbolicating local builds without lots of extra steps or delay; other than that concern, it sounds good to me.
Blocks: 1435934
Priority: -- → P1
We can generate symbols by ./mach buildsymbols, then remote profiler (on host) should read it and send it to perf-html.io. Although I write a WIP, it can show within 1 min.
It seems that symbolication still isn't working correctly with the latest fixes: https://perfht.ml/2w8tuFt What else do we need here?
Flags: needinfo?(mstange)
Flags: needinfo?(m_kato)
(In reply to Panos Astithas [:past] (please ni?) from comment #2) > It seems that symbolication still isn't working correctly with the latest > fixes: > > https://perfht.ml/2w8tuFt > > What else do we need here? I filed bug 1457706 about the fact that it's still not working for libxul.so. The fact that it's not working for system libraries is expected; the next step to fix that would probably be bug 1457481.
Depends on: 1457481, 1457706
Flags: needinfo?(mstange)
Flags: needinfo?(m_kato)
(In reply to Markus Stange [:mstange] from comment #3) > (In reply to Panos Astithas [:past] (please ni?) from comment #2) > > It seems that symbolication still isn't working correctly with the latest > > fixes: > > > > https://perfht.ml/2w8tuFt > > > > What else do we need here? > > I filed bug 1457706 about the fact that it's still not working for libxul.so. That bug has been fixed, and profiles from official Firefox builds now get proper symbols for Firefox code! Here's a profile I just collected: https://perfht.ml/2I7YDgW \o/
Depends on: 1481619
The last dependency was fixed, we're done here.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1507253
You need to log in before you can comment on or make changes to this bug.