Closed
Bug 1445081
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend v21
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8958641 -
Flags: review?(jdescottes)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8958643 -
Flags: review?(jdescottes)
Assignee | ||
Comment 5•7 years ago
|
||
Assignee | ||
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Comment on attachment 8958641 [details] [diff] [review]
rel-21-align.patch
Review of attachment 8958641 [details] [diff] [review]:
-----------------------------------------------------------------
Works for me but I have two questions about those "align" patches since that's the second in a row:
- what is driving the "alignment" in the bundle?
- why is there no commit associated with this?
In theory we should be able to trace back a release in m-c to a tag in GitHub and regenerate the exact same bundle from GitHub.
It seems like we can generate two completely different artifacts for a single release version?
::: devtools/client/debugger/new/README.mozilla
@@ -1,5 @@
> This is the debugger.html project output.
> See https://github.com/devtools-html/debugger.html
>
> -Version 19.2
> -Comparison: https://github.com/devtools-html/debugger.html/compare/release-19-1...release-19-2
Could you redo the patch to be on top of v20.0 ?
Attachment #8958641 -
Flags: review?(jdescottes) → review+
Comment 8•7 years ago
|
||
Looks like the patch is on top of the intermediary patch for v20.0 which was missing the README update. Consequently the patches here don't apply either on inbound or on central. But for inbound the conflict is only with the README so that's manageable.
Comment 9•7 years ago
|
||
Comment on attachment 8958643 [details] [diff] [review]
rel-21.patch
Review of attachment 8958643 [details] [diff] [review]:
-----------------------------------------------------------------
- Meta:
- assigned, P3, enhancement, blocks meta: OK
- commit message: OK
- less than 20 commits: OK
- TRY
- try run green: OK
- try run has rebuild: OK
- Manual test: OK
- README review: OK
- Properties file review: OK
- New files: OK
Attachment #8958643 -
Flags: review?(jdescottes) → review+
Updated•7 years ago
|
Severity: normal → enhancement
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•7 years ago
|
||
Attachment #8958641 -
Attachment is obsolete: true
Attachment #8958643 -
Attachment is obsolete: true
Attachment #8958809 -
Flags: review+
Assignee | ||
Comment 11•7 years ago
|
||
Attachment #8958810 -
Flags: review+
Comment 12•7 years ago
|
||
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5336cf59879b
Re-align webpack module ordering. r=jdescottes
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcb818464c50
Update Debugger Frontend v21. r=jdescottes
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5336cf59879b
https://hg.mozilla.org/mozilla-central/rev/bcb818464c50
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
Early results on http://firefox-dev.tools/performance-dashboard/tools/debugger.html?days=14&filterstddev=true seem to show a noticeable perf regression from v21:
- 4% on complicated.open
- 8% on custom.open
- 4% on custom.reload
- 3% on custom.pause
- 10% on custom close
- 5% on simple.open
(stepping tests are a bit too noisy to tell so early)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•