Closed
Bug 1445117
Opened 7 years ago
Closed 7 years ago
Remove duplicates from nsGkAtoms
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
nsGkAtoms has multiple atoms listed twice.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8958338 [details]
Bug 1445117 - Remove duplicates from nsGkAtoms.
https://reviewboard.mozilla.org/r/227272/#review233242
I think this is OK. What are the error messages going to be like in a future world where you simply *can't* repeat atom values?
Attachment #8958338 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
> What are the error messages going to be like in a
> future world where you simply *can't* repeat atom values?
The relevant code is here:
https://searchfox.org/mozilla-central/rev/8fa0b32c84f924c6809c690117dbd59591f79607/xpcom/ds/nsAtomTable.cpp#697-706
Currently we crash and print the name of the offending atom if you register a static atom that already exists as a dynamic atom. In the future we will be stricter and crash in the same way if you register a static atom that already exists as a static atom.
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/23178aea581b05805dec054001a35cf0a3bb7084
Bug 1445117 - Remove duplicates from nsGkAtoms. r=froydnj
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•