Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th) Reporter
	Description • 6 years ago

[Notes]:
- After encountering this issue, the Accessibility Features can no longer be turned of from that tab. If the "ON" button is clicked the button changes in a "Turing Off" spinner and the Accessibility features remain enabled.

[Affected versions]:
- Nightly (61.0a1) Try build (2018-03-12)

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Have the latest try build 61.0a1 from (2018-03-12) installed.
- The "Accessibility" option is checked in "Toolbar Options".

[Steps to reproduce]:
1. Open the Nightly try build with the profile from prerequisites and navigate to any website.
2. Press the "F12" key and enable Accessibility features.
3. Click the "ON" green button from the top left corer of the Web Console.
4. Close the Web Console.
5. Reopen the Web Console (F12 key) and observe the "Accessibility" tab. 

[Expected Results]:
- The Accessibility features are disabled.

[Actual results]:
- The Accessibility features are enabled and cannot be turned off from that tab.

[Additional Notes]:
- Attached a screen recording with the issue.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 1 • 6 years ago

Hi Cosmin,

Could you see if this build https://treeherder.mozilla.org/#/jobs?repo=try&revision=db9ba9649738461e89fa8ef361ff66ebcf5752d8 fixes the issue?

Thanks!

	Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th) Reporter
	Comment 2 • 6 years ago

Hi Yura,

I have retest this issue using the provided Nightly try build (2018-03-14) from comment 1 and the issue is no longer reproducible.
Tested on Windows 7 x64, Mac 10.12 and Arch Linux.

So I think we can close this issue as Resoled - Fixed.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 3 • 6 years ago

This one requires a patch so I'll get on it.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 4 • 6 years ago

The issue happened because walker reset method would instantiate a11y service (when looking up an accessible for root doc). This patch narrows down ways a11y service is accessed directly. It is now limited to places where we already know that the service is enabled, or when we are enabling the accessibility actor.

	Patrick Brosset <:pbro>
	Comment 5 • 6 years ago

Comment on attachment 8959205 [details] [diff] [review]
1445251 patch

Review of attachment 8959205 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

	Pulsebot
	Comment 6 • 6 years ago

Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f16989641e49
do not instantiate a11y service if it was already turned off when resetting accessible walker actor. r=pbro

	Andrei Ciure[:aciure]
	Comment 7 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/f16989641e49

	Daniel_A[:daschilean] [Please contact - liviu.seplecan@softvision.ro]
	Comment 8 • 6 years ago

Hi Yura,

I reproduced this issue on Windows 10 64bit with FF 61.0a1 (2018-03-27) (64-bit) using the latest build:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=499d93733484e632899a1f11d15189e5131a3594&selectedJob=170817771

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 9 • 6 years ago

I believe this is slightly different. I think the "...and cannot be turned off from that tab." part is not true any more. We had a discussion with jryans about this issue and it's OK for now to leave it as is. I will leave this open but remove it from the tracking bug.

	Julian Descottes [:jdescottes]
	Comment 10 • 6 years ago

Was about to log a new bug, and I am not sure what is the status here, but I have STRs to trigger the "Turning off" spinning indefinitely:

- open devtools a11y panel
- enable a11y features
- select console
- close toolbox
- open toolbox (with F12 so that it opens on console)
- close toolbox again
- open toolbox again (F12)
- go to a11y panel
- try to disable a11y service

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 11 • 6 years ago

(In reply to Julian Descottes [:jdescottes][:julian] from comment #10)
> Was about to log a new bug, and I am not sure what is the status here, but I
> have STRs to trigger the "Turning off" spinning indefinitely:
> 
> - open devtools a11y panel
> - enable a11y features
> - select console
> - close toolbox
> - open toolbox (with F12 so that it opens on console)
> - close toolbox again
> - open toolbox again (F12)
> - go to a11y panel
> - try to disable a11y service

Hmm, I can't seem to reproduce this one :(. Was this happening 100% of the time for you, Julian or just intermittently?

	Julian Descottes [:jdescottes]
	Comment 12 • 6 years ago

Indeed it's not 100% :( 

Yesterday I thought it was 100% but it was just very frequent (I can get it 5 times in a row, and then nothing for a few tests etc ...). I don't know if it's a race or a subtle difference in my STRs. And I don't have any error logged either. I'm on latest central + OSX

I'll try to play with this a bit more, see if I can get stable STRs.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 13 • 6 years ago

Thanks, I have a  feeling I might afteral extend our XPCOM a11y service and add a shutdown method instead of doing it via pref. This would help with stability there.

	Timea Cernea [:tbabos][inactive]
	Comment 14 • 6 years ago

Managed to reproduce the issue by following the STR from Comment 10. I could reproduce it 5/8 attempts on the latest Nightly version (Build ID: 20180420100056) on Windows 7.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 15 • 6 years ago

(In reply to Timea Babos from comment #14)
> Managed to reproduce the issue by following the STR from Comment 10. I could
> reproduce it 5/8 attempts on the latest Nightly version (Build ID:
> 20180420100056) on Windows 7.

Hi Timea, I have a test build with a possible fix https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4e8c64c96952621f434443a799595f426886e5e , could you see if you can reproduce it now?

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 16 • 6 years ago

See comment 15

	Timea Cernea [:tbabos][inactive]
	Comment 17 • 6 years ago

Hi Yura,

I cannot reproduce the issue on that build on  Mac OS X 10.12, Windows 10 x64 and Ubuntu 16.04 x64.

	Pulsebot
	Comment 19 • 6 years ago

Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4f8d6d96eaf
enable parent process accessibility service if child process one is enabled on startup. r=pbro

	Andrei Ciure[:aciure]
	Comment 20 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e4f8d6d96eaf

	Timea Cernea [:tbabos][inactive]
	Comment 21 • 6 years ago

The issue cannot be reproduced on the latest Nightly Firefox 61.0a1.(20180506220517/2018-05-06) on Windows 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x64, thus I will close the issue as VERIFIED FIXED.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 22 • 6 years ago

Comment on attachment 8972577 [details] [diff] [review]
1445251 patch follow up

This is one of the high priority bugs for a11y inspector panel.
[Feature/Bug causing the regression]: Not a regression, supports a11y inspector panel - one of high visibility changes in Fx61
[User impact if declined]: If declined, the panel sometimes can get in a state where accessibility service remains running in the child process but not in parent process. This is an issue because the panel gets out of sync.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: See description.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small change that just synchronizes a11y services running in content and parent processes.
[String changes made/needed]: No

	Ryan VanderMeulen [:RyanVM]
	Comment 23 • 6 years ago

Comment 20 landed on m-c when it was still tracking version 61. What needs uplifting still here?

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 24 • 6 years ago

Comment on attachment 8972577 [details] [diff] [review]
1445251 patch follow up

Ah, you are right, removing the flag.