Open
Bug 1445617
Opened 7 years ago
Updated 2 years ago
Disconnect harExportConnection from the store
Categories
(DevTools :: Netmonitor, enhancement, P3)
DevTools
Netmonitor
Tracking
(Not tracked)
NEW
People
(Reporter: Honza, Unassigned)
References
(Blocks 1 open bug)
Details
This is a follow up for bug 1436665
Net monitor app object created for WebExtension API isn't connected to the UI (net panel) since it doesn't have to exist at the time when extensions are using this API. We can also disconnect it from the store to make the HAR export process even faster.
Note that FirefoxConnector is using `getTimingMarker` selector (and `getState`) to get timing markers, this value should be probably calculated in FirefoxDataProvider
Honza
Reporter | ||
Comment 1•7 years ago
|
||
As soon as the NetMonitor is using new event emitter (should happen in bug 1382602) we can emit the payload from FirefoxDataProvider as new argument.
this.emit(EVENTS.REQUEST_ADDED, id, payload);
Having the payload associated with the event is needed for `NetMonitorApp.onRequestAdded` event handler. This handler is currently using `getDisplayedRequestById` that gets the payload from the store, but the request won't be there anymore. That's why we need the payload (+ actor in it) directly associated with the event.
Honza
Blocks: netmonitor-har
Depends on: 1382602
Reporter | ||
Updated•7 years ago
|
Priority: -- → P3
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•