Closed
Bug 1445766
Opened 7 years ago
Closed 7 years ago
Fix up some non-unified bustage in gfx/layers
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 file)
(deleted),
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
Over in bug 1086964, I'm getting rid of the no_pgo hack on Layers.cpp and LayerTreeInvalidation.cpp that is no longer needed. In review, I was asked to try moving them from SOURCES back to UNIFIED_SOURCES since no_pgo was the reason for being there in the first place, but my attempt to do so on Try didn't go swimmingly.
https://treeherder.mozilla.org/logviewer.html#?job_id=167999450&repo=try
--> Fixed with a couple gfx:: sprinkled on SingleTiledContentClient.cpp
https://treeherder.mozilla.org/logviewer.html#?job_id=167999443&repo=try
https://treeherder.mozilla.org/logviewer.html#?job_id=167999462&repo=try
https://treeherder.mozilla.org/logviewer.html#?job_id=167999461&repo=try
--> Fixed with a couple mozilla::ipc:: in RefCountedShmem.cpp and a TextureForwarder.h include in TextureDIB.cpp
Assignee | ||
Comment 1•7 years ago
|
||
This has gone through a number of iterations on Try already, but doing one more final run for kicks.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d40be67682f1cf470b53b837c8e2b1dbfe5559c&group_state=expanded
Attachment #8958969 -
Flags: review?(lsalzman)
Updated•7 years ago
|
Attachment #8958969 -
Flags: review?(lsalzman) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfe4b0a2e835
Fix some non-unified build bustage in gfx/layers. r=lsalzman
Comment 3•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•