(In reply to David Major [:dmajor] from bug 1086964 comment #12) > Probably the same for CTypes.cpp ...and actually it looks like there's a ton > of stuff in this moz.build with no clear reason for using SOURCES. Do you > feel like cleaning these up in a followup?

Just a note that moving RegExp.cpp into UNIFIED_SOURCES caused a lot of win32 orange in CI when I tried making that change in bug 1086964. Lots of timeouts suggesting big slowdowns.

Thanks for updating the comment for RegExp.cpp. I agree it's unclear whether some of those comments still apply (and, in some cases, what they even mean). Would be great to see this list trimmed.

(In reply to Jason Orendorff [:jorendorff] from comment #2) > Thanks for updating the comment for RegExp.cpp. > > I agree it's unclear whether some of those comments still apply (and, in > some cases, what they even mean). Would be great to see this list trimmed. Mostly, the files I had in mind were the ones that don't even have comments. There's a whole bunch of if CONFIG["FOO"]: SOURCES += foo.cpp