illumilor.e Reporter
	Description • 6 years ago

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180209193630

Steps to reproduce:

When closing firefox it does not offer warning when multiple tabs open

	Francesco Lodolo [:flod]
	Comment 1 • 6 years ago

Type about:config<enter> in the address bar. If a warning screen comes up, press the Be Careful button. 

At the top of the screen is a search bar. Type 

browser.tabs.warnOnClose

What's the value? If it's false, double click it to set it to true (that's the default value, btw).

	illumilor.e Reporter
	Comment 2 • 6 years ago

It is set to true

	Francesco Lodolo [:flod]
	Comment 3 • 6 years ago

Do you have any add-ons installed? Does it work normally on a new profile?
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

	illumilor.e Reporter
	Comment 4 • 6 years ago

It happens with no addons and in a new profile after I switch warnonclose to true

	Carmen Fat [:cfat] - Ecosystem QA (PTO until Sept 8th, please contact cmuresan@mozilla.com instead for any requests)
	Comment 5 • 6 years ago

Could you please retest this using the latest Nightly build and report back the results? (You can download the latest Nightly build from here https://goo.gl/57dpxn)
When doing this, please use a new clean Firefox profile, as mentioned in comment 3.

Thanks.

	Gingerbread Man
	Comment 7 • 6 years ago

Bug 1199055 - reporter doesn't follow up. It ends up duped to bug 502908.
This - reporter says browser.tabs.warnOnClose = true, meaning bug 502908 can't be the issue. Doesn't follow up.
Bug 1454189 - reporter files yet another duplicate.

	Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th)
	Comment 8 • 6 years ago

(In reply to illumilor.e from comment #4)
> It happens with no addons and in a new profile after I switch warnonclose to
> true

@illumilor on any Firefox new profiles the "browser.tabs.warnOnClose" pref is set to "true" by default and the warning is displayed if you close the browser when you have multiple tabs opened.
From your comment I understand that on your new Firefox profile, the "browser.tabs.warnOnClose" pref was set to "false" by default and after you change it to "true" the warning was no longer displayed. Is this correct?

However, only when you change the pref to "false", the warning is no longer displayed.

Can you also please provide the values for the below prefs?
- browser.showQuitWarning
- browser.warnOnQuit
- browser.tabs.warnOnClose
- browser.tabs.warnOnCloseOtherTabs

	illumilor.e Reporter
	Comment 9 • 6 years ago

I should said that it still closes even after warnonclose is set to true. That setting doesn't seem to change any behaviour when hitting ctrl+q

quitwarning=false
warnonquit=true
warnonclose=true
othertabs=true

	Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th)
	Comment 10 • 6 years ago

Thanks for your reply! 

By default the "browser.showQuitWarning" pref is set to "false" which means that if you have multiple tabs opened and you close Firefox no warning is displayed. However, after starting Firefox you have the "Restore Previous Session" option available and all the tabs can be restored.

In order to receive the warning when closing Firefox (Ctrl + Q), you should change the "browser.showQuitWarning" pref to "true".
@illumilor.e can you please change the pref to true and see if you get the warning? 

The "browser.tabs.warnOnClose" pref is set to "true" by default which means that if you have multiple tabs opened and you close the Firefox window by clicking the "X" button, you get a warning. So this pref doesn't cover the exit Firefox (Ctrl + Q) functionality.

	illumilor.e Reporter
	Comment 11 • 6 years ago

With browser.showQuitWarning set to true ctrl+q still does not show a confirmation/warning before quitting firefox.

	Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until September 8th)
	Comment 12 • 6 years ago

Thanks for testing this!

It seems that this issue is a similar to bug 502908. Considering this I will close this as dupe of it.