Closed Bug 144584 Opened 23 years ago Closed 22 years ago

Update localeVersion in 1.0.1 branch for newer milestone releases

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tao, Assigned: tao)

References

Details

(Whiteboard: [adt1 RTM] custrtm+ [ETa 06/29])

Attachments

(2 files, 2 obsolete files)

moz patch w/ 1.0.1rc1
(deleted), patch
tao
: review+
tao
: superreview+
Details | Diff | Splinter Review
ns patch w/ 1.0.1rc1
(deleted), patch
tao
: review+
tao
: superreview+
Details | Diff | Splinter Review
This is a routine work and might need to be part of the build config build
Hi, Don: Since ADT (jaimejr) suggested that this might belong to BuildConfig, would you please consult granrose if we should put this under one of his meta bugs to get blanket approval? thx
Blocks: 144547
Blocks: 143047
Keywords: nsbeta1+
Summary: Update localeVersion in 1.0.0 branch for newer milestone releases → Update localeVersion in 1.0.1 branch for newer milestone releases
Whiteboard: [adt1 RTM]
Whiteboard: [adt1 RTM] → [adt1 RTM] custrtm
Whiteboard: [adt1 RTM] custrtm → [adt1 RTM] custrtm+
Can we get a status update on this bug?
These localeVersion bugs are not "fixed" until a day or two before the actual milestone.
new owner ->tao
Assignee: dbragg → tao
Attached patch moz patch (obsolete) (deleted) — — Splinter Review
1.0.0final -> 1.0.1rc
Attached patch ns patch (obsolete) (deleted) — — Splinter Review
flip locale version: 1.0.0final -> 1.0.1rc
HI, leaf / dn: would you please r/sr these patches? They are the routine localeVersion # flipping tasks :-) You can compare them to patches in 142823.
Status: NEW → ASSIGNED
Comment on attachment 89493 [details] [diff] [review] moz patch r=leaf with the caveat or changing 1.0.1rc to 1.0.1rc1 (if we're going to have multiple rcs, let's start numbering them properly)
Attachment #89493 - Flags: review+
Comment on attachment 89494 [details] [diff] [review] ns patch r=leaf with the same caveat as the moz patch.
Attachment #89494 - Flags: review+
adt1.0.1+ (on ADT's behalf) approval for checkin into the 1.0 branch, pending drivers' approval and positive sr=. pls check this in asap, then add the "fixed1.0.1" keyword.
Keywords: adt1.0.1+, approval, mozilla1.0.1
Whiteboard: [adt1 RTM] custrtm+ → [adt1 RTM] custrtm+ [ETa 06/29]
Ew, "1.0.1rc"? Do we really expect localizations to change between 1.0.1 pre-release (if any) and the final? I'd have preferred plain "1.0.1". If localizations do happen to break between the two then oh well, casualty of a release candidate. (I'd have made a different argument for the 1.0 release candidates since those were a bigger deal with more change expected.) but ok, sr=dveditz on both patches whether you change it or not.
Attachment #89494 - Flags: superreview+
Attachment #89493 - Flags: superreview+
Attached patch moz patch w/ 1.0.1rc1 (deleted) — — Splinter Review
use 1.0.1rc1 instead
Attachment #89493 - Attachment is obsolete: true
Attachment #89494 - Attachment is obsolete: true
Attached patch ns patch w/ 1.0.1rc1 (deleted) — — Splinter Review
moz patch w/ 1.0.1rc1 instead of 1.0.1rc
Comment on attachment 89608 [details] [diff] [review] moz patch w/ 1.0.1rc1 inherit r=leaf from previous patch
Attachment #89608 - Flags: review+
Comment on attachment 89608 [details] [diff] [review] moz patch w/ 1.0.1rc1 inherit r=dveditz from previous patch
Attachment #89608 - Flags: superreview+
Comment on attachment 89609 [details] [diff] [review] ns patch w/ 1.0.1rc1 inherit r=leaf,sr=dviditz from previous patch
Attachment #89609 - Flags: superreview+
Attachment #89609 - Flags: review+
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+" keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
into the branch. Ying - please flip regca's as well, thx!
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: mozilla1.0.1+ → fixed1.0.1
Resolution: --- → FIXED
tao - how to verify?
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: