Dão Gottwald [:dao] Assignee
	Description • 6 years ago

The consumeoutsideclicks attribute should be used instead.

	Manish [:manishkk]
	Comment 1 • 6 years ago

:dao

need to remove these two lines only?
https://dxr.mozilla.org/mozilla-central/source/layout/xul/PopupBoxObject.h?q=PopupBoxObject&redirect_type=direct#58,60

	Dão Gottwald [:dao] Assignee
	Comment 2 • 6 years ago

(In reply to Manish Kumar from comment #1)
> :dao
> 
> need to remove these two lines only?

No. Here are the full lists of files where code needs to be removed:

https://searchfox.org/mozilla-central/search?q=enableRollup

https://searchfox.org/mozilla-central/search?q=setConsumeRollupEvent

	Dão Gottwald [:dao] Assignee
	Comment 3 • 6 years ago

(In reply to Dão Gottwald [::dao] from comment #0)
> The consumeoutsideclicks should be used instead.

And the noautohide attribute, respectively...

	Dão Gottwald [:dao] Assignee
	Comment 4 • 6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5de05ecf3dda2a6d989877477851118841cbbde0

	Neil Deakin
	Comment 5 • 6 years ago

Comment on attachment 8967300 [details] [diff] [review]
patch

-void
-nsXULPopupManager::EnableRollup(nsIContent* aPopup, bool aShouldRollup)
-{
-#ifndef MOZ_GTK
-  nsMenuChainItem* item = mPopups;
-  while (item) {

The caller to EnableRollup was incorrectly removed by bug 1278282. It should be restored, or at least, don't remove this code.

	Neil Deakin
	Comment 7 • 6 years ago

Also, I think you could now remove the PopupBoxObject include and the using line near the top of nsMenuPopupFrame.cpp since the popupboxobbject isn't used the file any more.

	Dão Gottwald [:dao] Assignee
	Comment 8 • 6 years ago

(In reply to Neil Deakin from comment #7)
> Also, I think you could now remove the PopupBoxObject include and the using
> line near the top of nsMenuPopupFrame.cpp since the popupboxobbject isn't
> used the file any more.

This came almost too late as I was already trying to push this, but without luck:

remote: WebIDL file dom/webidl/PopupBoxObject.webidl altered in changeset 78dab4ac5ae4 without DOM peer review
remote: 
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: 
remote: Changes to WebIDL files in this repo require review from a DOM peer in the form of r=...
remote: This is to ensure that we behave responsibly with exposing new Web APIs. We appreciate your understanding..
remote: 
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.d_webidl hook failed

*sigh*

Obviously this isn't a Web API.

	Pulsebot
	Comment 10 • 6 years ago

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c5124a18c41
Remove PopupBoxObject::enableKeyboardNavigator/enableRollup/setConsumeRollupEvent in favor of DOM attributes. r=enn,peterv

	Arthur Iakab [arthur_iakab]
	Comment 11 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/7c5124a18c41

	Dão Gottwald [:dao] Assignee
	Comment 12 • 6 years ago

page to remove: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/setConsumeRollupEvent

	Chris Mills [:cmills]
	Comment 13 • 6 years ago

(In reply to Dão Gottwald [::dao] from comment #12)
> page to remove:
> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Method/
> setConsumeRollupEvent

Page deleted; let me know if the deletion message seems appropriate. Thanks!