Closed
Bug 1445947
Opened 7 years ago
Closed 7 years ago
Do not assert about re-protection of pages with the same flags.
Categories
(Core :: JavaScript: GC, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: nbp, Assigned: nbp)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehoogeveen
:
review+
|
Details | Diff | Splinter Review |
Handling code to avoid re-protection might be more efficient, but sometimes, we do not care as much about the efficiency and more about the correctness, such as in Bug 1437600.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED
Priority: -- → P1
|
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8959126 -
Flags: review?(emanuel.hoogeveen)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8959126 [details] [diff] [review]
Remove re-protection warnings from Windwos VirtualProtect calls.
Review of attachment 8959126 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, I don't think these assertions are particularly useful.
Attachment #8959126 -
Flags: review?(emanuel.hoogeveen) → review+
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a33782324009
Remove re-protection warnings from Windows VirtualProtect calls. r=ehoogeveen
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•