Closed
Bug 1446234
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend v23
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8959401 -
Flags: review?(jdescottes)
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
alright, i think we upset the toolbox debugger test again...
Updated•7 years ago
|
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Comment 5•7 years ago
|
||
Comment on attachment 8959401 [details] [diff] [review]
rel-23.patch
Review of attachment 8959401 [details] [diff] [review]:
-----------------------------------------------------------------
2 Bugs need to be synchronized (I can't handle it this week).
- commit message: OK
- less than 20 commits: OK
- try: KO, (we need to re-add browser_browser_toolbox_debugger.js to the list of "other" tests)
- manual test: Waiting for a patch that has a green try
- readme: KO
::: devtools/client/debugger/new/README.mozilla
@@ +5,2 @@
>
> +Comparison: https://github.com/devtools-html/debugger.html/compare/release-23...release-22
Wrong order :)
Comparison: https://github.com/devtools-html/debugger.html/compare/release-22...release-23
::: devtools/client/debugger/new/test/mochitest/browser_dbg-chrome-create.js
@@ -10,5 @@
> -// There are shutdown issues for which multiple rejections are left uncaught.
> -// See bug 1018184 for resolving these issues.
> -const { PromiseTestUtils } = scopedCuImport("resource://testing-common/PromiseTestUtils.jsm");
> -PromiseTestUtils.whitelistRejectionsGlobally(/File closed/);
> -PromiseTestUtils.whitelistRejectionsGlobally(/NS_ERROR_FAILURE/);
Needs sync from https://bugzilla.mozilla.org/show_bug.cgi?id=1442312
::: devtools/client/debugger/new/test/mochitest/head.js
@@ +37,5 @@
> "chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js",
> this
> );
>
> var { Toolbox } = require("devtools/client/framework/toolbox");
needs sync from https://bugzilla.mozilla.org/show_bug.cgi?id=1440321
Attachment #8959401 -
Flags: review?(jdescottes)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8959401 -
Attachment is obsolete: true
Attachment #8959523 -
Flags: review?(jdescottes)
Assignee | ||
Comment 7•7 years ago
|
||
Comment 8•7 years ago
|
||
Comment on attachment 8959523 [details] [diff] [review]
rel-23-2.patch
Review of attachment 8959523 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8959523 -
Flags: review?(jdescottes) → review+
Assignee | ||
Comment 9•7 years ago
|
||
Attachment #8959523 -
Attachment is obsolete: true
Attachment #8959568 -
Flags: review+
Comment 10•7 years ago
|
||
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/588e5d942bca
Update Debugger Frontend v23. r=jdescottes
Comment 11•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•