Closed Bug 1446329 Opened 6 years ago Closed 6 years ago

Add the spinbuttons binding to TB after it's removal in core

Categories

(Thunderbird :: General, enhancement)

Product:
Thunderbird
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird60 fixed, thunderbird61 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 61.0
Tracking Flags:
Tracking Status
thunderbird60 --- fixed
thunderbird61 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

spinbuttons.patch
(deleted), patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review 
The spinbutton binding was removed in core. We need it mainly for the extension compatibility.
Attached patch spinbuttons.patch (deleted) — — Splinter Review 
Best is to test it with the extension from bug 1443215 (attachment 8959265 [details]).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8959500 - Flags: review?(jorgk)
Attachment #8959500 - Flags: approval-comm-beta?
Comment on attachment 8959500 [details] [diff] [review]
spinbuttons.patch

Thanks, tested with the add-on.
Attachment #8959500 - Flags: review?(jorgk)
Attachment #8959500 - Flags: review+
Attachment #8959500 - Flags: approval-comm-beta?
Attachment #8959500 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2e4ff3621e13
Add the spinbuttons binding to TB after it's removal in core. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
I'll spin a Daily with this in a minute unless the previous push reports bustage.
Target Milestone: --- → Thunderbird 61.0
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/29339165eb51
Follow-up: fix lint issue. r=me DONTBUILD
Blocks: tb-war-on-xbl
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: