Closed Bug 1446438 Opened 7 years ago Closed 7 years ago

[Normandy] Channel filter doesn't match exact beta version

Categories

(Firefox :: Normandy Client, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: aflorinescu, Assigned: mythmon)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

[PreRequisites:] 1. Set the app.normandy.dev_mode preference to true to run recipes immediately on startup. 2. Set the app.normandy.logging.level preference to 0 to enable more logging. 3. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90. 4. Set the preference value for app.normandy.api_url set to https://normandy.stage.mozaws.net/api/v1 [Steps:] 1. Open staging Control center and create any type of recipe with the following filter: normandy.version == '60.0b3' || normandy.version == '61.0a1' 2. Open Nightly 61 with a new profile and set pre-requisites. 3. Close Nightly and open beta b3 using the same profile. [Actual Result:] 2. Recipe created at step 1 is fetched and executed. 3. Recipe created at step 1 is fetched but not executed. [Expected Result:] Both Beta 3 and Nightly should execute the recipe.
Component: Normandy Server → Normandy Client
Note that the tracking flags are not relevant for this bug, since they give out the feeling of this being a regression, when they should be read: Nightlies unaffected, Betas affected, Releases unaffected Since I could reproduce this bug on 59.0b11, this is not a regression after bug 1436113, but seems like rather a problem related to beta channel.
Normandy reads its version from `Services.appinfo.version`. On Nightly that reports 61.0a1, but on Beta it reports just 60.0. There is also `AppConstants.MOZ_APP_VERSION`, which behaves identically, and `AppConstants.MOZ_APP_VERSION_DISPLAY` which has the desired behavior (60.0b4 on Fx60 beta 4). I'm not sure why these variations exist. Matt: Which of these behaviors would you prefer? I'd lean towards VERSION_DISPLAY's version (60.0b4), since it provides more information and is still compatible with how we usually handle versions in filter expressions (`normandy.version >= '60'`).
Flags: needinfo?(mgrimes)
I personally want it to map however RelMan thinks about this stuff.
I think I agree with Mythmon here. More information is always nice to have.
Flags: needinfo?(mgrimes)
Assignee: nobody → mcooper
Status: NEW → ASSIGNED
Severity: normal → minor
Priority: -- → P1
Comment on attachment 8961043 [details] Bug 1446438 - Use exact beta version in Normandy filtering https://reviewboard.mozilla.org/r/229790/#review235750 Yep, this makes sense, r=me. I take it we're satisfied that existing filters in recipes currently in use won't be broken by this change? I guess they've always had to deal with number-letter-number because of nightly versioning, but just doublechecking... :-)
Attachment #8961043 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs from comment #6) > I take it we're satisfied that existing filters in recipes currently in use > won't be broken by this change? I guess they've always had to deal with > number-letter-number because of nightly versioning, but just > doublechecking... :-) Yes, this is something I'm satisfied with. Of the 22 recipes currently active, all of them compare versions using string ranges, which won't be affected by this change. Of the 390 recipes ever run on Normandy, only 5 of them use exact version comparisons without also filtering to only run on release. 4 of these were targeting a point release (43.0.1), and the fifth looks like it was only trying to target Release and got Beta by accident as well.
Pushed by mcooper@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93a43f1d8ea0 Use exact beta version in Normandy filtering r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: