Open Bug 1446725 Opened 7 years ago Updated 2 years ago

Wait for appropriate event before continuing the tests for favicon load

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

Product:
Firefox
Component:
Tabbed Browser
Type:
enhancement

Tracking

()

People

(Reporter: arai, Unassigned)

References

Details

Separated from bug 1442465. The following tests were waiting for the promise returned by BrowserTestUtils.removeTab, but the promise is removed in bug 1442465: * browser/components/originattributes/test/browser/browser_favicon_firstParty.js * browser/components/originattributes/test/browser/browser_favicon_userContextId.js * browser/components/privatebrowsing/test/browser/browser_privatebrowsing_favicon.js What those tests actually should do is wait for some event after closing a tab, before continuing the next test, to ensure that the network request for the first tab is not observed in the next test. In bug 1442465 patch, I just made them to wait for the next event tick, and looks like it works, but it would be better specifically wait for some event.
Component: Session Restore → Tabbed Browser
actually this doesn't block.
No longer blocks: 1442465
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1442465
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.