Makoto Kato [:m_kato] Assignee
	Description • 6 years ago

Except to table access and XPCOM method for c-c, we can remove more nsIDOMElement  usages.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900)
	Comment 2 • 6 years ago
mozreview-review

Comment on attachment 8960071 [details]
Bug 1446861 - Remove more nsIDOMElement usages from editor.

https://reviewboard.mozilla.org/r/228850/#review234518

::: commit-message-0b997:3
(Diff revision 1)
> +Bug 1446861 - Remove more nsIDOMElement usages from editor. r?masayuki
> +
> +Except to table access and XPCOM methods for c-c, tests and etc, we can remove

s/Except to/Except ?

::: editor/libeditor/EditorEventListener.cpp:1105
(Diff revision 1)
>      // listener in the chain changed the focus.
>      if (editableRoot) {
> -      nsIFocusManager* fm = nsFocusManager::GetFocusManager();
> +      nsFocusManager* fm = nsFocusManager::GetFocusManager();
>        NS_ENSURE_TRUE(fm, NS_OK);
>  
> -      nsCOMPtr<nsIDOMElement> element;
> +      nsCOMPtr<nsIContent> focusedContent = fm->GetFocusedContent();

Looks like that this can be nsIContent* since FindFirstNonChromeOnlyAccessContent() is safe to call without grabbing it.

	Pulsebot
	Comment 3 • 6 years ago

Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60d8158308b2
Remove more nsIDOMElement usages from editor. r=masayuki

	Andreea Pavel [:apavel]
	Comment 4 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/60d8158308b2